Skip to content

Commit 115978d

Browse files
authored
Remove use of denorm in mad fp16 test because we can't specify denorm preserve across compilers (#652)
Remove use of denorm values in this test because although using '-denorm preserve' for DXC makes this test pass on the machines it is failing on, there is currently no option in the clang compiler. So, the test would still need to be xfailed for the clang compiler. Closes #563 Closes #562
1 parent 37cb3c8 commit 115978d

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

test/Feature/HLSLLib/mad.fp16.test

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ Buffers:
2424
- Name: M
2525
Format: Float16
2626
Stride: 8
27-
Data: [ 0x7e00, 0xfc00, 0x03FF, 0x8000, 0x0000, 0x7c00, 0x3c00, 0xbc00, 0x0000, 0x3c00, 0x3e00, 0xc300 ]
28-
# NaN, -Inf, denorm, -0, 0, Inf, 1, -1, 0, 1, 1.5, -3.5
27+
Data: [ 0x7e00, 0xfc00, 0x4500, 0x8000, 0x0000, 0x7c00, 0x3c00, 0xbc00, 0x0000, 0x3c00, 0x3e00, 0xc300 ]
28+
# NaN, -Inf, 5, -0, 0, Inf, 1, -1, 0, 1, 1.5, -3.5
2929
- Name: A
3030
Format: Float16
3131
Stride: 8
@@ -34,17 +34,17 @@ Buffers:
3434
- Name: B
3535
Format: Float16
3636
Stride: 8
37-
Data: [ 0x7e00, 0xfc00, 0x03FF, 0x8000, 0x0000, 0x7c00, 0x3c00, 0xbc00, 0x3c00, 0x0000, 0xc580, 0x3c00 ]
38-
# NaN, -Inf, denorm, -0, 0, Inf, 1, -1, 1, 0, -5.5, 1
37+
Data: [ 0x7e00, 0xfc00, 0x4500, 0x8000, 0x0000, 0x7c00, 0x3c00, 0xbc00, 0x3c00, 0x0000, 0xc580, 0x3c00 ]
38+
# NaN, -Inf, 5, -0, 0, Inf, 1, -1, 1, 0, -5.5, 1
3939
- Name: Out
4040
Format: Float16
4141
Stride: 8
4242
FillSize: 32
4343
- Name: ExpectedOut
4444
Format: Float16
4545
Stride: 8
46-
Data: [ 0x7e00, 0x7e00, 0x07FE, 0x0000, 0x0000, 0x7c00, 0x4000, 0, 0x3c00, 0x3c00, 0x48c0, 0xcc20, 0x4000, 0x48c0, 0x7c00, 0xfc00 ]
47-
# NaN, NaN, 0.00012195110, 0, 0, Inf, 2, 0, 1, 1, 9.5, -16.5, 2, 9.5, Inf, -Inf
46+
Data: [ 0x7e00, 0x7e00, 0x4900, 0x0000, 0x0000, 0x7c00, 0x4000, 0, 0x3c00, 0x3c00, 0x48c0, 0xcc20, 0x4000, 0x48c0, 0x7c00, 0xfc00 ]
47+
# NaN, NaN, 10, 0, 0, Inf, 2, 0, 1, 1, 9.5, -16.5, 2, 9.5, Inf, -Inf
4848
Results:
4949
- Result: Test0
5050
Rule: BufferFloatULP
@@ -83,12 +83,6 @@ DescriptorSets:
8383
Binding: 3
8484
#--- end
8585

86-
# Bug https://github.com/llvm/offload-test-suite/issues/562
87-
# XFAIL: QC && Vulkan
88-
89-
# Bug https://github.com/llvm/offload-test-suite/issues/563
90-
# XFAIL: NV && Vulkan
91-
9286
# REQUIRES: Half
9387
# RUN: split-file %s %t
9488
# RUN: %dxc_target -enable-16bit-types -Gis -HV 202x -T cs_6_5 -Fo %t.o %t/source.hlsl

0 commit comments

Comments
 (0)