Use ROW.Reset in EraseInDisplay instead of printing millions of spaces per line #2197

PankajBhojwani · miniksa · commit 2096fa5e1f1f · 2019-08-01T13:48:51.000-07:00
diff --git a/src/cascadia/TerminalCore/TerminalApi.cpp b/src/cascadia/TerminalCore/TerminalApi.cpp
@@ -337,11 +337,9 @@ bool Terminal::EraseInDisplay(const DispatchTypes::EraseType eraseType)
         // and we have to make sure we erase that text
         auto eraseStart = _mutableViewport.Height();
         auto eraseEnd = _buffer->GetLastNonSpaceCharacter(_mutableViewport).Y;
-        auto eraseIter = OutputCellIterator(UNICODE_SPACE, _buffer->GetCurrentAttributes(), _mutableViewport.RightInclusive() * (eraseEnd - eraseStart + 1));
         for (SHORT i = eraseStart; i <= eraseEnd; i++)
         {
-            COORD erasePos{ 0, i };
-            _buffer->Write(eraseIter, erasePos);
+            _buffer->GetRowByOffset(i).Reset(_buffer->GetCurrentAttributes());
         }
 
         // Reset the scroll offset now because there's nothing for the user to 'scroll' to

Original file line number	Diff line number	Diff line change
`@@ -337,11 +337,9 @@ bool Terminal::EraseInDisplay(const DispatchTypes::EraseType eraseType)`
`337`	`337`	`// and we have to make sure we erase that text`
`338`	`338`	`auto eraseStart = _mutableViewport.Height();`
`339`	`339`	`auto eraseEnd = _buffer->GetLastNonSpaceCharacter(_mutableViewport).Y;`
`340`		`- auto eraseIter = OutputCellIterator(UNICODE_SPACE, _buffer->GetCurrentAttributes(), _mutableViewport.RightInclusive() * (eraseEnd - eraseStart + 1));`
`341`	`340`	`for (SHORT i = eraseStart; i <= eraseEnd; i++)`
`342`	`341`	`{`
`343`		`- COORD erasePos{ 0, i };`
`344`		`- _buffer->Write(eraseIter, erasePos);`
	`342`	`+ _buffer->GetRowByOffset(i).Reset(_buffer->GetCurrentAttributes());`
`345`	`343`	`}`
`346`	`344`
`347`	`345`	`// Reset the scroll offset now because there's nothing for the user to 'scroll' to`