`minecraft:tall_seagrass` Rendered Incorrectly

[KokeCacao]

Version: deepslate@npm:0.23.5

The above images are rendered with chunkSize: 16 and chunkSize: 8 respectively, following #14, no other settiings are changed.
Interestingly, the render is only incorrect when render from a certain camera angle and changing chunk size does not help mitigate the issue unlike #14.

You can reproduce with the following schematic

{
  MinecraftDataVersion: 3955,
  Version: 7,
  SubVersion: 1,
  Metadata: {
    Name: "Koke_Cacao",
    Author: "Koke_Cacao",
    Description: "",
    EnclosingSize: {
      x: 16,
      y: 16,
      z: 16
    },
    TimeCreated: 1740706858701L,
    TimeModified: 1740706858701L,
    RegionCount: 1,
    TotalVolume: 4096,
    TotalBlocks: 4096
  },
  Regions: {
    MineCraftDiffusionModel: {
      BlockStatePalette: [
        {
          Name: "minecraft:air"
        },
        {
          Name: "minecraft:sand"
        },
        {
          Name: "minecraft:water"
        },
        {
          Name: "minecraft:tall_seagrass"
        },
        {
          Name: "minecraft:seagrass"
        },
        {
          Name: "minecraft:kelp_plant"
        },
        {
          Name: "minecraft:kelp"
        }
      ],
      BlockStates: [I;-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,4963967029874599058L,-6606137901526473878L,7901314506266724660L,-5236972615602719470L,-2490977529114324119L,-7946930782416966074L,5103863950180165331L,-3274780337006797750L,7654177977846106566L,2671842154762544420L,-3077853470346649015L,8157323260105362854L,2635535654702621842L,-7760506372111408279L,7901173489605495096L,-5273071782460836718L,-2501427907239931027L,5347692826499706406L,3810689755644503763L,-3293885519261033911L,7616873712902621638L,2635249290826032274L,-3077888655249583543L,-8560056148880110170L,2635249222106555538L,-7905747460161236407L,5270499406287882532L,2635249153387078802L,-7689574678047452343L,5271061264090155302L,2635249222106556050L,-7905747460161105335L,5270498306774157604L,2635249153387078802L,-7689574678047452599L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7689574678047452599L,5270498314136733988L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7689574678047452599L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7689574678047452599L,5270498314136733988L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7689574678047452599L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7689574678047452599L,5270498314136733988L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7617517084009524663L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7617517084009524663L,5270498314136733988L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498314136733988L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498314136733988L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498314405169444L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498313369176356L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498313218705700L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498315364092196L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L,2635249153387078802L,-7905747460161236407L,5270498306774157604L],
      Position: {
        x: -8,
        y: -8,
        z: -8
      },
      Size: {
        x: 16,
        y: 16,
        z: 16
      },
      PendingBlockTicks: [I;],
      PendingFluidTicks: [I;],
      TileEntities: [],
      Entities: []
    }
  }
}

Edit: specifically, assuming camera always looking at the center, render is only correct when viewed from 45deg >= azimuth >= -45deg and elevation <= 45deg
Edit: this only happen to waterlogged block that is Inherent according to https://minecraft.wiki/w/Waterlogging (e.g. waterlogged chests do not have such problem). Add a waterlogged tag to tall_seagrass does not help.

[KokeCacao]

Some more images showing the issue: top image is viewed from outside of water, botttom image is viewed from inside of water.

[KokeCacao]

I think I figured out the issue: if the surface block has a lower x/z value than the rendered waterlogged target, the rendered waterlogged target would not render. Not sure why it only apply to Inherent though... I tested with similar and even non-waterloggable blocks in Java like dead_bush, none of them have similar issue.

When forcing tall_seagrass to be non-waterlogged block (

deepslate/src/core/BlockState.ts

Line 39 in 0db3e4b

|| this.is('seagrass') || this.is('tall_seagrass')

), the issue still happens.

Edit: Feels like it has to do with block rendering order, culling, and depth buffer. But why are tall_seagrass special?

[KokeCacao]

kelp_plant is cursed. A temporary resolution would be changing the actual block to dead_bush then change uv mapping of dead_bush to the value of kelp_plant: "block/dead_bush":[2032,256,16,320]. Image renders correctly. Still need time to debug deeper.

... [1000 years later.png] ...

Okay, didn't know that kelp_plant and other stuff in the image above are considered as semi-transparent just like water. So the main issue is indeed: #31 (comment) I'll see if I can tackle this problem.

[KokeCacao]

Solved it. Will make a PR when I got time... and maybe give a proper fix for misode/vscode-nbt#78 as well.

[KokeCacao]

Solved it. Will make a PR when I got time... and maybe give a proper fix for misode/vscode-nbt#78 as well.

See #55