-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Origin
From review comments on PRs #152 and #153 by @cmungall:
PR #153 (Osteoporosis):
"the generic pharmacotherapy terms need chebi qualifiers/postcomps"
"needs qualifiers" (Denosumab)
"needs chemical qualifiers" (Teriparatide)
PR #152 (Atrial Fibrillation):
"use post-composition for pharmocotherapy terms"
"indicate role" (Anticoagulation)
"use post-composition" (Rate Control)
Problem
Multiple treatments in these PRs use MAXO:0000058 (pharmacotherapy) as the treatment term without specifying the therapeutic_agent CHEBI qualifiers. Per the schema design, when using generic MAXO terms like pharmacotherapy, the specific drug should be captured via therapeutic_agent with CHEBI terms.
Affected Treatments
PR #153 - Osteoporosis
- Denosumab (RANKL inhibitor) - needs CHEBI term for denosumab
- Teriparatide (PTH analog) - needs CHEBI term for teriparatide
- Romosozumab (Sclerostin inhibitor) - needs CHEBI term for romosozumab
PR #152 - Atrial Fibrillation
- Anticoagulation (warfarin, DOACs) - needs CHEBI terms for warfarin and/or DOACs
- Rate Control (beta blockers, CCBs, digoxin) - needs CHEBI terms for representative drugs
- Rhythm Control (amiodarone, flecainide, sotalol) - needs CHEBI terms
Expected Pattern
From Wilson's Disease example in the codebase:
treatment_term:
preferred_term: pharmacotherapy
term:
id: MAXO:0000058
label: pharmacotherapy
therapeutic_agent:
- preferred_term: zinc acetate
term:
id: CHEBI:62984
label: zinc acetateProposed Action
- Look up appropriate CHEBI terms for each drug
- Add
therapeutic_agentarrays to treatment_term blocks in both PR files - Validate with
just validateandjust validate-terms
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers