AIX configure can't handle `CC="ccache gcc"`

[sxa]

Spotted earlier while testing on an AIX 7.3 machine, but this is unlikely to be specific to this machine.

When trying to enable ccache with export CC='ccache gcc-12' and the equivalent CXX the configure step fails. In the maine builds we have a gcc-12 synlink to ccache which causes it to use the wrapper implicitly.

IMHO it would be preferable to have it explicitly show ccache gcc in the logs to make it clear that it is using ccache so we should investigate what is causing this to fail.

$ export CC="/opt/ccache-3.7.4/bin/ccache gcc-12"
$ export CXX="/opt/ccache-3.7.4/bin/ccache gcc-12"
$ python3.12 ./configure
Node.js configure: Found Python 3.12.12...
WARNING: Could not recognize `gas`: 
WARNING: warnings were emitted in the configure phase
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/opt/freeware/lib64/python3.12/subprocess.py", line 548, in run
    with Popen(*popenargs, **kwargs) as process:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/freeware/lib64/python3.12/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/opt/freeware/lib64/python3.12/subprocess.py", line 1955, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/opt/ccache-3.7.4/bin/ccache gcc-12'
gyp: Call to '/opt/freeware/bin/python3.12 -c "import os; import subprocess; CXX=os.environ.get('CXX', 'g++'); subprocess.run([CXX, '-dumpversion'])"' returned exit status 1 while in /home/iojs/sxa/node1/node.gyp. while trying to load /home/iojs/sxa/node1/node.gyp
Error running GYP
$ 

[sxa]

Looks like it may not be handling the space in the desired way and is trying to exec it all as a single argv[0] - I haven't seen this issue on Linux. Easily reproducible it seems:

>>> print(CXX)
/opt/ccache-3.7.4/bin/ccache gcc-12
>>> subprocess.run([CXX, '-dumpversion'])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/freeware/lib64/python3.12/subprocess.py", line 548, in run
    with Popen(*popenargs, **kwargs) as process:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/freeware/lib64/python3.12/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/opt/freeware/lib64/python3.12/subprocess.py", line 1955, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/opt/ccache-3.7.4/bin/ccache gcc-12'
>>> 

[richardlau]

@sxa is it shell sensitive? (Are you running in ksh or bash?)

[sxa]

User error: CXX was set to gcc-12 isntead of g++-12.

[sxa]

Hmmm I may havebeen too hasty with that last comment - it's failing again for me with it set correctly.

[richardlau]

@sxa I think this is coming from

node/common.gypi

Line 601 in d1e26f6

'gcc_major': '<!(<(python) -c "import os; import subprocess; CXX=os.environ.get(\'CXX\', \'g++\'); subprocess.run([CXX, \'-dumpversion\'])")'

which is AIX-specific.