Update module helm.sh/helm/v3 to v4

[frewilhelm]

Description

helm v4 was released and we need to support it in ocm lib v1 and v2.

Scope

• Check the helm input method (v2)
• Check Helm upload/download (v1)
• Check breaking changes for helm

Time Box: 5 days (as learning opportunity)

Done Criteria

• Create respective issues to tackle the migration

[fabianburth]

Did the migration of legacy ocm to the point that the unit tests run based on helm/v4. I did not perform any manual tests yet!

Breaking Changes (that affected us)

• ContentCache

  • helms previous cache was based on chart name + version which was likely to collide (short lived cached)
  • helm v4 replaced that with a content based (hash) based cache (long lived cache)
  • previously, the repository cache location was automatically also used for that cache, now it is a dedicated setting that has to be set (e.g. on the downloader)

• Chart Package API Version (charts/v2/...)

  • apparently, helm is preparing for v3 chart version
  • as preparation, they moved code specific to handling v1 and v2 charts into a v2 package

• Custom Logging Interfaces replaced by Go standard logging library (slog)

  • at some places, they took away the possibility to inject a logger

• Notices

  • jfrogplugin uploader test
    • the helm jfrogplugin upload test did not work
    • we did not notice it because we forgot to include the directory in the Makefile
    • the weird thing is, to me it appears as if this could have never worked (the test and the tested code have not been changed since they were initially committed, i guess might have been an oversight)