fix(1560): add more explicit errors on get cv (#1787)

On-behalf-of: SAP <[email protected]>

<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it
Users complain about confusing error messages in `get cv`.
Errors that are related to technical problems, like missing docker
binaries or other things, are not properly communicated and hidden by a
generic `invalid component reference` message.
This PR logs more details in case of technical errors.

#### Which issue(s) this PR is related to
Fixes: #1560

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Matthias Bruns <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gerald Morrison <[email protected]>
Co-authored-by: GitHub Actions Bot <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: souleb <[email protected]>
Co-authored-by: Uwe Krueger <[email protected]>

Author: 6 people

Makefile

@@ -89,6 +89,10 @@ format:
 check: ## Run golangci-lint.
 	go tool golangci-lint run --timeout 10m --config .github/config/golangci.yaml $(EFFECTIVE_DIRECTORIES)
 
+.PHONY: check-fix
+check-fix: ## Run golangci-lint.
+	go tool golangci-lint run --fix --timeout 10m --config .github/config/golangci.yaml $(EFFECTIVE_DIRECTORIES)
+
 .PHONY: force-test
 force-test:
 	@go test -vet=off --count=1 $(EFFECTIVE_DIRECTORIES)

api/credentials/internal/utils.go

@@ -19,7 +19,9 @@ func CredentialsForConsumer(ctx ContextProvider, id ConsumerIdentity, unknownAsE
 	}
 	creds, err := src.Credentials(cctx)
 	if err != nil {
-		return nil, errors.Wrapf(err, "lookup credentials failed for %s", id)
+		unknownErr := errors.ErrUnknown(KIND_CREDENTIALS, id.String())
+		err = errors.Wrapf(err, "unable to receive credentials for %s", id)
+		return nil, errors.Wrap(unknownErr, err)
 	}
 	return creds, nil
 }

cmds/ocm/commands/ocmcmds/common/handlers/comphdlr/typehandler.go

@@ -9,6 +9,7 @@ import (
 	"github.com/mandelsoft/goutils/errors"
 
 	clictx "ocm.software/ocm/api/cli"
+	"ocm.software/ocm/api/credentials"
 	"ocm.software/ocm/api/ocm"
 	"ocm.software/ocm/api/ocm/compdesc"
 	metav1 "ocm.software/ocm/api/ocm/compdesc/meta/v1"
@@ -159,12 +160,19 @@ func (h *TypeHandler) get(repo ocm.Repository, elemspec utils.ElemSpec) ([]outpu
 		if err != nil {
 			evaluated = nil
 			if h.resolver != nil {
+				if errors.IsErrUnknownKind(err, credentials.KIND_CREDENTIALS) {
+					return nil, errors.Wrapf(err, "failed to get component version %q", name)
+				}
+
+				origErr := err
 				comp, err := ocm.ParseComp(name)
 				if err != nil {
+					err = errors.Wrap(origErr, err)
 					return nil, errors.Wrapf(err, "invalid component version reference %q", name)
 				}
 				if comp.IsVersion() {
 					cv, err := h.resolver.LookupComponentVersion(comp.Component, *comp.Version)
+					err = errors.Wrap(origErr, err)
 					if err != nil {
 						return nil, err
 					}
@@ -174,7 +182,7 @@ func (h *TypeHandler) get(repo ocm.Repository, elemspec utils.ElemSpec) ([]outpu
 						evaluated.Ref.CompSpec = comp
 						evaluated.Version = cv
 						evaluated.Repository = cv.Repository()
-						h.session.Closer(cv)
+						_, _ = h.session.Closer(cv)
 					}
 				}
 			}