Skip to content

load_external_url should have a proper timeout set #286

@norbertcyran

Description

@norbertcyran

requests.get which is used by _load_external_url method, by default does not have any timeout set, while it's recommended for nearly all the production code to set some proper value. Currently, it's possible that premailer hangs forever when there are issues with a resource server.

Ref: https://requests.readthedocs.io/en/latest/user/quickstart/#timeouts

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions