refactor: move vscode settings setup to pnpm postinstall hook

- Remove vscodesettings.js execution from make install targets
- Add .vscode/settings.json to .gitignore
- Remove .vscode/settings.json from git tracking
- Add postinstall hook to package.json to run vscodesettings.js
- Fix script to properly check if settings.json exists before reading

Author: wesleybl

.gitignore

@@ -44,6 +44,9 @@ lib64
 # locales
 locales/*.json
 
+# VSCode
+.vscode/settings.json
+
 # Tests
 /tests/bin
 /tests/develop-eggs

.vscode/settings.json

@@ -75,9 +75,7 @@ clean: ## Clean development environment
 
 .PHONY: install
 install: ## Set up development environment
-	# Setup ESlint for VSCode
 	pnpm i
-	node packages/scripts/vscodesettings.js
 	make build-deps
 
 ##### Documentation

Makefile

@@ -3,6 +3,7 @@
   "private": true,
   "scripts": {
     "preinstall": "npx only-allow pnpm",
+    "postinstall": "node packages/scripts/vscodesettings.js",
     "watch": "pnpm --filter @plone/registry --filter @plone/client --filter @plone/components --filter @plone/providers watch",
     "build:deps": "pnpm --filter @plone/registry build",
     "build:all": "pnpm --filter @plone/registry --filter @plone/client --filter @plone/components --filter @plone/providers --filter @plone/react-router build",

package.json

@@ -3,10 +3,12 @@ import fs from 'fs';
 import { parse, stringify } from 'comment-json';
 
 let vscodeSettingsJSON;
-if (fs.existsSync('.vscode')) {
+if (fs.existsSync('.vscode') && fs.existsSync('.vscode/settings.json')) {
   vscodeSettingsJSON = parse(fs.readFileSync('.vscode/settings.json', 'utf8'));
 } else {
-  fs.mkdirSync('.vscode');
+  if (!fs.existsSync('.vscode')) {
+    fs.mkdirSync('.vscode');
+  }
   fs.writeFileSync('.vscode/settings.json', '{}');
   vscodeSettingsJSON = parse(fs.readFileSync('.vscode/settings.json', 'utf8'));
 }

packages/scripts/vscodesettings.js

@@ -61,8 +61,6 @@ clean: ## Clean development environment
 
 .PHONY: install
 install: ## Set up development environment
-	# Setup ESlint for VSCode
-	node packages/scripts/vscodesettings.js
 	pnpm i
 	make build-deps