Make closure compiler configurable?

[maxime-tournier]

Hi,

When upgrading emscripten-glfw to a recent version I noticed my release build starting throwing exceptions when trying to access mod.FS.mkdir.

This does not happen with debug builds, which helped my narrow it down to the closure compiler doing something wrong. My current workaround is to simply modify emscripten-glfw cmake files to avoid passing "$<$<CONFIG:Release>:--closure=1>" in link flags.

It's obviously a bug in emscripten's closure compiler and I'll file an issue there as well, but in the meantime how about adding a cmake option to control this behavior? I can file a PR if you want me to.

Best regards,

[ypujante]

I understand what you are talking about, but why are you using the CMakefile? The recommended way to use this project is to use the port instead. The CMakefile is really intended to build the examples/demo code.

That being said, yes I am open to a PR. And if you open an issue on the Emscripten side, please reference this bug.

Thank you

[maxime-tournier]

The recommended way to use this project is to use the port instead

Interesting.

Is there a way to use my own fork of emscripten-glfw with the emscripten port system, or at least pin glfw to a specific version?

And if you open an issue on the Emscripten side, please reference this bug.

Will do. Thanks for your feedback!

[ypujante]

Is there a way to use my own fork of emscripten-glfw with the emscripten port system, or at least pin glfw to a specific version?

Absolutely. The easiest way would be to run the cmake target create-archive on your fork.

This will generate 2 files: a zip file and a checksum file. Note that the checksum is also printed on stdout.

You can then use/copy the file port/emscripten-glfw3.py into your own project and do the following:

• change EXTERNAL_PORT = f'https://github.com/pongasoft/emscripten-glfw/releases/download/v{TAG}/emscripten-glfw3-{TAG}.zip' to EXTERNAL_PORT = f'file://<absolute path to the zip file generated previously>'
• update SHA12 with the checksum previously printed (or found in the 2nd file)

Then to use with Emscripten, you add the command line option (for BOTH compile and link phases, that is very important), --use-port=<absolute path to the copied/edited emscripten-glfw3.py file>

The port will take care of compiling with the right flags... And you can use port options as described in the documentation for this library.

You can obviously copy the zip file under your project tree and check it in.

[ypujante]

I forgot to mention that if you want to pin it to a specific version, you can simply use the port file that is checked in. For example, you can check my other project https://github.com/pongasoft/webgpu-shader-toy

Under external/emscripten-ports I have a copy (meaning pinned) version of emscripten-glfw3.py and I don't rely on the version that is bundled with Emscripten.

And in my CMakeLists.txt, I use it like this:

set(wgpu_shader_toy_options
    "--use-port=${CMAKE_SOURCE_DIR}/external/emscripten-ports/emscripten-glfw3.py:optimizationLevel=${PORTS_OPTIMIZATION_LEVEL}:disableWebGL2=true"
    "--use-port=${CMAKE_SOURCE_DIR}/external/emscripten-ports/imgui.py:backend=glfw:renderer=wgpu:disableDemo=${IMGUI_DISABLE_DEMO}:optimizationLevel=${PORTS_OPTIMIZATION_LEVEL}:disableDefaultFont=true")

target_compile_options(wgpu_shader_toy PUBLIC
    "${wgpu_shader_toy_options}"
    "-fwasm-exceptions"
)

target_link_options(wgpu_shader_toy PUBLIC
    "-fwasm-exceptions"
    "${wgpu_shader_toy_options}"
    "--js-library" "${CMAKE_CURRENT_LIST_DIR}/src/js/lib_wgpu_shader_toy.js"
)

[maxime-tournier]

Thanks a lot, I'll give it a go.