Bug: incorrect link to submission in the author guide + all policy in the same place (#340)

* fix: submission link for authors lead to empty issue

* enh: typos and avoid maintenance policy duplication

* Update how-to/author-guide.md

Author: lwasser

how-to/author-guide.md

@@ -1,4 +1,4 @@
-# Peer Review Guide for Python Open Source Authors / Authors
+# Guide for Python Package Authors & Maintainers
 
 :::{toctree}
 :hidden:
@@ -21,7 +21,7 @@ Finding & Onboarding Reviewers <finding-reviewers>
 
 Are you considering submitting a package for review with pyOpenSci? You've
 come to the right place! Below you will find the steps that you need to follow
-to submit a package to pyOpenSci for peer review along with some additional resources that you may find useful.
+to submit a package to pyOpenSci for peer review.
 
 ## Peer review resources
 
@@ -82,19 +82,19 @@ Read about our peer review policies.
 Before you begin this process, [please be sure to read the review process guidelines](../our-process/policies).
 
 ```{note}
-**Before you consider submitting to us please consider the following:**
+**Before you consider submitting to us, please consider the following:**
 
 1. Please be sure that you have time to devote to making changes to your
 package. During review, you will receive feedback from an editor and two reviewers. Changes could
 take time. Please consider this before submitting to us. You can read more about the timeline to make changes in our [peer review policies page](../our-process/policies).
-2. Peer review is lead by a diverse group of volunteer editors and reviewers.
+2. A diverse group of volunteer editors and reviewers leads peer review.
 Please be considerate when engaging with everyone online.
 ```
 
 ## 1. Do you plan to continue to maintain your package?
 
 One of the goals of pyOpenSci is to maintain a curated list of
-community-approved, maintained and vetted tools that support open science workflows.
+community-approved, maintained, and vetted tools that support open science workflows.
 
 As such, we review packages that will be useful to the community
 and maintained over time. While we understand that burnout is real,
@@ -109,7 +109,7 @@ your package to a journal that is more focused on publication only.
 
 If you have a team of people maintaining your package, please be sure
 that the submitting author is the person who "owns" or leads that maintenance.
-That person will become the long term point of contact
+That person will become the long-term point of contact
 for pyOpenSci.
 
 - Please also include the names of all maintainers on the project
@@ -124,8 +124,8 @@ either:
 
 please consider submitting it directly to a publisher like the
 Journal of Open Source Software (JOSS). A publisher like JOSS has less
-emphasis on long term software maintenance and focuses more on
-publication quality and citation / credit.
+emphasis on long-term software maintenance and focuses more on
+publication quality and citation/credit.
 ```
 
 ## 2. Does Your Package Meet Packaging Requirements?
@@ -137,11 +137,11 @@ pyOpenSci.
 
 If you have questions about any of the elements listed below, you can
 check out our [pyOpenSci Python packaging guide](https://www.pyopensci.org/python-package-guide) which includes an overview discussion of best practices
-for Python packaging including discussions of:
+for Python packaging, including discussions of:
 
 - Tools that you can use to create your package
 - Tools for creating and publishing documentation.
-- Resources for creating files such as the README file, code of conduct, contributing guide and more.
+- Resources for creating files such as the README file, code of conduct, contributing guide, and more.
 
 ```{include} ../appendices/editor-in-chief-checks.md
 
@@ -160,10 +160,13 @@ surrounding:
 * Creating and publishing documentation
 * Anything related to our peer review process.
 
-Also check back on our [Packaging Guide](https://www.pyopensci.org/python-package-guide),
-to be updated this Spring 2023. This guide is designed to review the dynamic
-ecosystem of Python packaging tools that you can use to create a high quality
-Python package.
+Also, check our [Packaging Guide](https://www.pyopensci.org/python-package-guide).
+This guide includes:
+
+* a [beginner-friendly tutorial](https://www.pyopensci.org/python-package-guide/tutorials/create-python-package.html) for creating pure Python packages
+* [An overview of the packaging tool ecosystem
+that you can use to create a high-quality
+Python package.](https://www.pyopensci.org/python-package-guide/package-structure-code/python-package-build-tools.html)
 ```
 
 ## 3. Is Your Package in Scope for pyOpenSci?
@@ -188,7 +191,7 @@ Click here to view our technical and domain scope requirements.
 
 To submit your package for peer review, you can
 open an issue in our [pyopensci/software-review repo](https://github.com/pyOpenSci/software-review/issues/new/choose/)
-repository and fill out the [Submit Software for Review](https://github.com/pyOpenSci/software-review/issues/new?assignees=&labels=1%2Feditor-checks%2C+New+Submission%21&template=submit-software-for-review.md&title=) issue template.
+repository and fill out the [Submit Software for Review](https://github.com/pyOpenSci/software-submission/issues/new?template=submit-software-for-review.md) issue template.
 
 ## 5. Editor-in-Chief Reviews Package for Scope and Minimal Infrastructure Criteria
 
@@ -205,11 +208,11 @@ Click here to view the editor checks that will be used to evaluate your package.
 
 ## 6. The Review Begins
 
-If your package meets minimal criteria for being
-reviewed it may then be given to an editor with appropriate domain experience
+If your package meets the minimal criteria for being
+reviewed, it may then be given to an editor with appropriate domain experience
 to manage the review process. That editor will assign 2-3 reviewers to review your
 package. Reviewers will be asked to provide review feedback as comments on your
-issue within **3 weeks**. Reviewers also can open issues in your package repository.
+issue within **3 weeks**. Reviewers can also open issues in your package repository.
 We prefer issues that link back to the review as they document changes made to your
 package that were triggered by our review process.
 
@@ -218,12 +221,12 @@ package that were triggered by our review process.
 You should respond to reviewers’ comments within **2 weeks** of the
 last-submitted review. You can make updates to your package at any time. We
 encourage ongoing conversations between authors and reviewers. See the
-[guide for package reviewers](reviewer-guide.md) for more details about reviewers engagement with package
+[guide for package reviewers](reviewer-guide.md) for more details about reviewers' engagement with package
 maintainers during a review.
 
 ## 8. Acceptance into pyOpenSci
 
-Once the reviewers are happy with changes that you've made to the package, the
+Once the reviewers are happy with the changes that you've made to the package, the
 editor will review everything and accept your package into the pyOpenSci ecosystem.
 Congratulations! You are almost done!
 
@@ -232,31 +235,31 @@ Congratulations! You are almost done!
 Congratulations on being accepted into the pyOpenSci community of maintainers!
 Once your package is approved, a few things will happen:
 
-1. We will ask you to ensure that your package is being tracked / archived using
-   Zenodo. You will then want to created a tagged release representing the version of the
+1. We will ask you to ensure that your package is being tracked/archived using
+   Zenodo. You will then create a tagged release representing the version of the
    package accepted by pyOpenSci.
 1. We will ask you to add the pyOpenSci badge [![pyOpenSci Peer Reviewed](https://pyopensci.org/badges/peer-reviewed.svg)](https://github.com/pyOpenSci/software-review/issues/issue-number) to the
    top of your **README.md** file.
 1. We will promote your package on our social media channels!
-1. We will invite you to write a blog on our website spotlighting your package. The blogs that our maintainers write are some of the most popular content on the website!
+1. We will invite you to write a blog on our website spotlighting your package. The blogs our maintainers write are among the most popular content on the website!
 
-If you wish to go on to submit your package to JOSS, you can do so now. Remember that JOSS will accept our review as theirs so you DO NOT need to go through another review. Read more below.
+If you'd like to submit your package to JOSS, you can do so now. Remember that JOSS will accept our review as theirs, so **you DO NOT need to go through another review**. Read more below.
 
 ### Journal of Open Source Software (JOSS) Submission
 
-PyOpenSci has a partnership with JOSS where our review is accepted by JOSS by
+pyOpenSci has a [partnership with JOSS](JOSS), where our review is accepted by JOSS by
 default if the package fits into the JOSS scope.
 
 - When you submit your package for pyOpenSci review, you can opt to include a
   submission to JOSS after passing pyOpenSci review. In this case, your package
-  will evaluated by JOSS through the pyOpenSci review
+  will be evaluated by JOSS through the pyOpenSci review
 - To complete the JOSS submission, you will also need to craft a **paper.md**
-  file describing the package following JOSS' standards (see below). More detail on the requirements for JOSS can be found on [their website](https://joss.readthedocs.io/en/latest/submitting.html#what-should-my-paper-contain).
-- If you choose to opt into the pyOpenSci / JOSS partnership in your review,
+  file describing the package following JOSS' standards (see below). More details on the requirements for JOSS can be found on [their website](https://joss.readthedocs.io/en/latest/submitting.html#what-should-my-paper-contain).
+- If you choose to opt into the pyOpenSci/JOSS partnership in your review,
   you DO NOT need to go through a second review with JOSS. JOSS accepts our review
-  for theirs. Please start a review process with JOSS and reference the pyOpenSci
+  as theirs. Please start a review process with JOSS and reference the pyOpenSci
   review issue where your package was accepted. Make sure
-  that you let the JOSS editor know that we have already accepted your package. The JOSS editor will review your paper and once that is accepted you now have a JOSS DOI and badge to display on your README file as well!
+  that you let the JOSS editor know that we have already accepted your package. The JOSS editor will review your paper. Once your package is accepted, you will be given a JOSS cross-ref-enabled DOI and badge to display on your README file.
 
 ```{note}
 Acceptance to pyOpenSci does not guarantee acceptance to JOSS. In particular,
@@ -268,23 +271,34 @@ are usually not accepted by JOSS. Be sure to review JOSS's
 before writing up a paper about your package.
 ```
 
-## Post review - now what?
+## Post review - welcome to the pyOpenSci community!
+
+Congratulations! Once your package has been accepted into the pyOpenSci ecosystem, you'll be invited to join our [community Slack](https://join.slack.com/t/pyopensci/shared_invite/zt-39qitgkqb-gZTIo79xCJhS5kSxW1yNfg) where you can connect with other package maintainers, get help with maintenance questions, and stay updated on community developments.
+
+### Ongoing support from pyOpenSci
+
+We're committed to supporting you throughout your package's maintenance journey:
 
-Once you have been accepted into the pyOpenSci ecosystem, you will
-be invited to join our Slack channel.
+**Annual check-ins**: We'll reach out each year to see how your package is doing and learn about any updates we can help highlight through our blog, social media, or newsletter.
 
-We also will keep in touch with you, periodically checking in to ensure that package maintenance is going well and to better understand ways in which pyOpenSci can support you.
+**Community resources**: Take advantage of our Slack community to connect with other maintainers, share experiences, and get advice on common maintenance challenges. We're also building additional resources and tools to help package maintainers succeed.
 
-If at any time, you need to step down from maintaining your package,
-or you need help with maintenance, please let us know - preferably
-in advance. We will try to help you by either:
+**Maintenance assistance**: If you have specific maintenance challenges, our Slack community is a great place to ask questions. There is a lot of packaging and community expertise in our vibrant community!
 
-- Finding a new maintainer to take over your project (or additional maintainers to support maintenance) or
-- Sunsetting your package.
+### When you need help or want to step down
 
-If the package is sunsetted, we will remove it from our curated list
+Life changes and priorities shift. If maintaining your package becomes challenging, please reach out to us. We're here to help, and we have several options:
+
+- **Finding co-maintainers or new maintainers**: If you are interested, we can try to connect you with community members interested in contributing to or taking over maintenance of your package.
+- **Package archival**: If maintenance isn't sustainable, we can work together [to archive your package](https://www.pyopensci.org/python-packages.html#archived-packages).
+
+If the package is archived, we will remove it from our curated list
 of vetted tools.
 
-### Communication with pyOpenSci and removing tools from our vetted tool list
+### Maintenance policies
 
-To ensure packages that we support and advocate are maintained, if your package is accepted and we are not able to get in touch with you through normal communication channels (GitHub, email) after reaching out for at least 1-2 months, we will remove your package from our list of vetted tools. We will also remove any blogs written that highlight your tool.
+For detailed information about our maintenance expectations, annual check-in process, and archival procedures, please take a look at our [post-review process documentation](post-review-process). Remember, you maintain full ownership of your package. We're here to support you, not interfere with your development process.
+
+:::{tip}
+We will [follow our package archive process to determine whether your package should be archived.](archive-process)
+:::

our-process/policies.md

@@ -54,7 +54,6 @@ submit it to pyOpenSci for review. This provides:
   find a new maintainer and/or help sunset the tool.
 
 (coi)=
-
 ## Conflict of interest for reviews and editors
 
 Following criteria are meant to be a guide for what constitutes a conflict of
@@ -85,14 +84,16 @@ At any time, an author can choose to have their submission put on hold
 status will be revisited every 3 months. If after one year there has been
 no movement on the review, the issue will be closed.
 
+(post-review-process)=
 ## After acceptance: package ownership and maintenance
 
 Package authors are expected to maintain and develop their software and
 retain
-ownership of it after acceptance into pyOpenSci, as per the peer review
+ownership of it after acceptance into pyOpenSci, according to the peer review
 agreement acknowledged upon submission. This maintenance commitment should
 last for at least two years. The pyOpenSci team will not interfere with
-day-to-day tool maintenance unless explicitly added as collaborators.
+day-to-day tool maintenance unless someone in the community is explicitly added as
+a project collaborator.
 
 If you need to step down from maintaining your accepted pyOpenSci package,
 please promptly notify the pyOpenSci Editor-in-Chief or Software Review Lead.
@@ -119,17 +120,16 @@ flagged. At that time, pyOpenSci editorial team member will contact the package
 maintainers to evaluate the maintenance status of their package.
 
 (archive-process)=
-
 ### Package maintenance and maintainer responsiveness
 
 If, after one year, package maintainers are unresponsive to requests for
 package fixes or messages from the pyOpenSci team, we will initiate
 discussions about the package's ongoing inclusion within the pyOpenSci
 ecosystem.
 
-In cases where a package is heavily used by the community, we may
+In cases where the community heavily uses a package, we may
 collaborate with the community to identify reasonable next steps, such as
-assisting in finding a new maintainer. If a solution for ongoing package
+assisting in finding a new maintainer. If a solution for the ongoing package
 maintenance is not found, the package will be archived within the pyOpenSci
 ecosystem.
 
@@ -138,9 +138,12 @@ working with the new maintainers to register the newly forked package within
 our ecosystem. The original package will be archived with a link to the new
 fork.
 
+We will also add a note to any blogs written that highlight your tool that
+the package is no longer maintained.
+
 ### Quality commitment
 
-pyOpenSci strives to develop and promote high quality research software. To
+pyOpenSci strives to develop and promote high-quality research software. To
 ensure that your software meets our criteria, we review all of our submissions
 as part of the Software Peer Review process. We expect that you will continue
 to maintain a package that has been accepted continually.