Skip to content

Commit 7aeadaf

Browse files
author
GitHub Action
committed
🐛 Fix ESM webSocket import issue
We are getting this error when using in ESM enviroment: ``` TypeError: ws.Server is not a constructor at expressWs (file:///Users/dawidkisielewski/coding/reedsy/reedsy-editor/node_modules/@reedsy/express-ws/src/index.js:44:20) at EditorServer.startWebSocketServer (file:///Users/dawidkisielewski/coding/reedsy/reedsy-editor/packages/server/build/editor-server.js:146:25) at EditorServer.start (file:///Users/dawidkisielewski/coding/reedsy/reedsy-editor/packages/server/build/editor-server.js:43:20) at process.processTicksAndRejections (node:internal/process/task_queues:105:5) ```
1 parent b7a68fd commit 7aeadaf

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@reedsy/express-ws",
3-
"version": "5.0.0-reedsy-3.0.2",
3+
"version": "5.0.0-reedsy-3.0.3",
44
"description": "WebSocket endpoints for Express applications",
55
"exports": {
66
"require": {

src/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import http from 'http';
77
import express from 'express';
8-
import ws from 'ws';
8+
import { WebSocketServer } from 'ws';
99

1010
import websocketUrl from './websocket-url.js';
1111
import addWsMethod from './add-ws-method.js';
@@ -40,7 +40,7 @@ export default function expressWs(app, httpServer, options = {}) {
4040
// allow caller to pass in options to WebSocketServer constructor
4141
const wsOptions = options.wsOptions || {};
4242
wsOptions.server = server;
43-
const wsServer = new ws.Server(wsOptions);
43+
const wsServer = new WebSocketServer(wsOptions);
4444

4545
wsServer.on('connection', (socket, request) => {
4646
if ('upgradeReq' in socket) {

0 commit comments

Comments
 (0)