Commit 25de749
committed
[cppyy] Consider Python
The `std::make_unique` function is Pythonized to avoid unnecessary code
generation by TClingCallFunc, which might also go wrong (as reported in
GitHub issue #19122).
There is a fallback to calling the original `make_unique` for builtin
types (introduced in [1]), but we don't need that if we know the builtin
type can be readily used in the `unique_ptr` constructor, as is the case
for `int` and `float`.
Hence, this commit suggests to not use the fallback for `int` and
`float`, which also closes #19122 because no wrapper code has to be
generated anymore.
[1] wlav/cppyy@62a97c9int and float for make_unique optimization1 parent f687d1d commit 25de749
File tree
2 files changed
+7
-2
lines changed- bindings/pyroot/cppyy/cppyy
- python/cppyy
- test
2 files changed
+7
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
156 | 163 | | |
157 | 164 | | |
158 | 165 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
438 | 438 | | |
439 | 439 | | |
440 | 440 | | |
441 | | - | |
442 | 441 | | |
443 | 442 | | |
444 | 443 | | |
| |||
458 | 457 | | |
459 | 458 | | |
460 | 459 | | |
461 | | - | |
462 | 460 | | |
463 | 461 | | |
464 | 462 | | |
| |||
0 commit comments