Skip to content

Three-Tier Preserved Variables with Server Exclusions and Visual UI #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caffeinated92 merged 9 commits into from
Jan 7, 2026
Merged

Three-Tier Preserved Variables with Server Exclusions and Visual UI #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
016e0b3
feat: Add MySQL and Preserved Variables CNF management endpoints and …
caffeinated92 Jan 6, 2026
7021fe7
feat: Add MySQL/MariaDB default values configuration file for replica…
caffeinated92 Jan 6, 2026
d5658ca
feat: three-tier preserved variables with server exclusions and visua…
caffeinated92 Jan 6, 2026
f7d37a5
feat: remove MySQL defaults CNF endpoints from API documentation
caffeinated92 Jan 6, 2026
9aa64b6
feat: implement deployed values tracking in VariablesMap with mutex p…
caffeinated92 Jan 6, 2026
d39ce89
feat: update variable sync status display to show 'Synced' with icon
caffeinated92 Jan 7, 2026
8921440
move preserved before runtime for better grouping
caffeinated92 Jan 7, 2026
ecf53bf
feat: add HasConfigDiff field and HasDifferences method for config co…
caffeinated92 Jan 7, 2026
18a9c4d
feat: enhance config diff indicators with clickable navigation to Var…
caffeinated92 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions cluster/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,11 @@ type Cluster struct {
SessionManager *tty.SessionManager `json:"-"`
SysBenchTpcMResults []SysBenchTpcResultPerMinute
OpenSVCStats atomic.Value `json:"-"`
// Per-cluster preserved variables (replaces ProvDBConfigPreserveVars mechanism)
preservedVars map[string]string `json:"-"`
preservedVarsExcludeServers map[string]map[string]bool `json:"-"` // varName -> {serverID -> true}
preservedVarsLoaded bool `json:"-"`
preservedVarsMutex sync.RWMutex `json:"-"`
}

type SlavesOldestMasterFile struct {
Expand Down Expand Up @@ -551,6 +556,17 @@ func (cluster *Cluster) InitFromConf() {

cluster.LoadAppConfigs()

// Configurator generates base configuration from tags, which is overridden by:
// 1. Cluster-wide preserved variables
// 2. Server-specific preserved variables

// Initialize preserved variables before server initialization
// This replaces the old ProvDBConfigPreserveVars mechanism
if err := cluster.initPreservedVars(); err != nil {
cluster.LogModulePrintf(cluster.Conf.Verbose, config.ConstLogModGeneral, config.LvlWarn,
"Failed to pre-initialize preserved variables: %v (will retry on demand)", err)
}

err = cluster.newServerList()
if err != nil {
cluster.LogModulePrintf(cluster.Conf.Verbose, config.ConstLogModGeneral, config.LvlErr, "Could not set server list %s", err)
Expand Down
12 changes: 12 additions & 0 deletions cluster/cluster_acl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,18 @@ func (cluster *Cluster) IsURLPassACL(strUser string, URL string, errorPrint bool
}
}
if cluster.APIUsers[strUser].Grants[config.GrantClusterSettings] {
if strings.Contains(URL, "/api/clusters/"+cluster.Name+"/settings/mysql-defaults-cnf") {
return true
}
if strings.Contains(URL, "/api/clusters/"+cluster.Name+"/settings/actions/save-mysql-defaults-cnf") {
return true
}
if strings.Contains(URL, "/api/clusters/"+cluster.Name+"/settings/preserved-variables-cnf") {
return true
}
if strings.Contains(URL, "/api/clusters/"+cluster.Name+"/settings/actions/save-preserved-variables-cnf") {
return true
}
if strings.Contains(URL, "/api/clusters/"+cluster.Name+"/settings/actions/reload") {
return true
}
Expand Down
Loading