-
-
Notifications
You must be signed in to change notification settings - Fork 95
Description
It appears that the github actions that fire on PR merges to master are building, packaging, and overwriting the most recent release based on the latest commit to the master branch. The result is that the binaries and and package files in the release are no longer based on the tagged commit indicated by the release name.
cf. the actions run upon merge of #569:
- we see the commit hash of the PR's merge commit being checked out so the homer-app binary and other artifacts can be built
- a release package is built and labeled 1.5.3, which is the version number of the most recent existing release
- the packaged artifacts are uploaded and overwrite the existing 1.5.3 release artifacts
The release page for 1.5.3 shows that the release artifacts are far more recent than the tagged commit, and the release artifact checksums have been modified since last week.
I believe the issue is that the Build Packages, Archive Frontend, and Upload Release steps are being run on merges to master when perhaps it would be more appropriate for them to run only when github.even_name == 'release' ?