-
Notifications
You must be signed in to change notification settings - Fork 38
Description
Discussed in #177
Originally posted by RafaelKr December 3, 2024
We're creating a role called Portal Customer. We'd like to use the role key portal_customer for that. Especially because for Symfony the role would be called ROLE_SULU_PORTAL CUSTOMER (note the space) without setting the key.
I'd like to create a PR, but we have the following options:
-
Create a new configuration key in
config/packages/sulu_community.yamlwith the pathsulu_community.website.role_namecorresponding to theroleconfiguration option. -
Create the PR to https://github.com/sulu/sulu and adjust the following line to replace spaces with underscores: https://github.com/sulu/sulu/blob/15a676466de29d815d016b37dd7cb97fef1cc76d/src/Sulu/Bundle/SecurityBundle/Entity/Role.php#L130. Of course this would be a breaking change so the PR would be against the 3.0 branch.
Also the AsciiSlugger could be used which is available from Symfony 5.0, using_as the seperator. -
Doing both PRs
What is your preferred approach to that? Of course I'm open to other solutions too.
Edit: AsciiSlugger is available starting from Symfony 5.0, before I told it's available from 7.1 as that is what the version selector in the documentation suggested.