Skip to content

Commit 1ac803c

Browse files
committed
Minor updates
1 parent b90a98a commit 1ac803c

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

NEWS.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66

77
* `col_select` works correctly when combined with `.name_repair` for files with
88
duplicate column names (#687).
9+
10+
* `read_*()` functions now correctly load from non-file connections when using
11+
`col_select` (#720).
912

1013
* When a string variable has a date and/or time format `read_*()` functions now
1114
warn and treat the variable as a plain string instead of throwing an error

tests/testthat/test-haven-sas.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ test_that("col_select works with .name_repair and renaming for duplicate names",
167167
# Test renaming
168168
res3 <- read_xpt(path, col_select = c(a = id...3, b = id...1), .name_repair = "universal")
169169
expect_equal(res3, set_names(df[c(3, 1)], c("a", "b")))
170-
}
170+
})
171171

172172
test_that("date/times with character data throw a warning (#747)", {
173173
df = data.frame(

0 commit comments

Comments
 (0)