Rework col_select behaviour #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* col_select now uses tidyselect::eval_select instead of the deprecated vars_select (including variable renaming) * name_repair implementation has been moved from as_tibble() in the C++ code to the `read_*()` functions so that it works correctly with col_select
hadley
approved these changes
Jan 9, 2026
Member
hadley
left a comment
hadley
left a comment
There was a problem hiding this comment.
Looks like a nice simplification!
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the
col_selectimplementation for theread_*()functions, with elated changes to.name_repair.col_selectnow usestidyselect::eval_select()instead of the deprecatedvars_select(). Thecols_skipargument for thedf_parse*()functions now uses integer indices instead of names as a result.col_selectimplementation has been cleaned up and now successfully supports renaming and variable reordering (closecol_selectdoes not work as documented #685).name_repairimplementation has been moved fromas_tibble()in the C++ code to theread_*()functions so that it works correctly withcol_select(close Interaction between.name_repairandcol_select#687).col_select(read_sav fails on zipped files when using col_select #720).