Add logic to detecte duplicate paths

Author: Marc Schöchlin

NEWS.rst

@@ -5,6 +5,205 @@ Release notes
 
 .. towncrier release notes start
 
+towncrier 25.8.0.dev0 (2025-09-25)
+==================================
+
+Features
+--------
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+- AA (`#1111 <https://github.com/twisted/towncrier/issues/1111>`_)
+
+
+Test Backend
+------------
+
+No significant changes.
+
+
+Test Frontend
+-------------
+
+No significant changes.
+
+
+towncrier 25.8.0.dev0 (2025-09-25)
+==================================
+
+Features
+--------
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+
+
+Main Platform
+-------------
+
+Features
+~~~~~~~~
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+
+
+Secondary
+---------
+
+Bugfixes
+~~~~~~~~
+
+- wollo (`#345 <https://github.com/twisted/towncrier/issues/345>`_)
+
+
+towncrier 25.8.0.dev0 (2025-09-25)
+==================================
+
+Features
+--------
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+
+
+Main Platform
+-------------
+
+Features
+~~~~~~~~
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+
+
+Secondary
+---------
+
+Bugfixes
+~~~~~~~~
+
+- wollo (`#345 <https://github.com/twisted/towncrier/issues/345>`_)
+
+
+towncrier 25.8.0.dev0 (2025-09-25)
+==================================
+
+Features
+--------
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+
+
+Main Platform
+-------------
+
+Features
+~~~~~~~~
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+
+
+Secondary
+---------
+
+Bugfixes
+~~~~~~~~
+
+- wollo (`#345 <https://github.com/twisted/towncrier/issues/345>`_)
+
+
+towncrier 25.8.0.dev0 (2025-09-25)
+==================================
+
+Features
+--------
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+
+
+Main Platform
+-------------
+
+Features
+~~~~~~~~
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+
+
+Secondary
+---------
+
+Bugfixes
+~~~~~~~~
+
+- wollo (`#345 <https://github.com/twisted/towncrier/issues/345>`_)
+
+
+towncrier 25.8.0.dev0 (2025-09-25)
+==================================
+
+Features
+--------
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+
+
+Main Platform
+-------------
+
+Features
+~~~~~~~~
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+
+
+Secondary
+---------
+
+Bugfixes
+~~~~~~~~
+
+- wollo (`#345 <https://github.com/twisted/towncrier/issues/345>`_)
+
+
+towncrier 25.8.0.dev0 (2025-09-25)
+==================================
+
+Features
+--------
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+
+
+Main Platform
+-------------
+
+Features
+~~~~~~~~
+
+- wall (`#123 <https://github.com/twisted/towncrier/issues/123>`_)
+
+
+Secondary
+---------
+
+No significant changes.
+
+
+towncrier 25.8.0.dev0 (2025-09-25)
+==================================
+
+No significant changes.
+
+
+Main Platform
+-------------
+
+No significant changes.
+
+
+Secondary
+---------
+
+No significant changes.
+
+
 towncrier 25.8.0 (2025-08-30)
 =============================
 

pyproject.toml

@@ -81,15 +81,15 @@ exclude = [
     issue_pattern = "\\d+"
 
     [[tool.towncrier.section]]
-        path = ""
+    path = ""
 
     [[tool.towncrier.section]]
-    name = "Main Platform"
-    path = ""
+    name = "Test Backend"
+    path = "backend-api"
 
     [[tool.towncrier.section]]
-    name = "Secondary"
-    path = "secondary"
+    name = "Test Frontend"
+    path = "frontend"
 
     [[tool.towncrier.type]]
         directory = "feature"

src/towncrier/_settings/load.py

@@ -4,6 +4,7 @@
 from __future__ import annotations
 
 import atexit
+import collections
 import dataclasses
 import os
 import re
@@ -12,9 +13,10 @@
 from collections.abc import Mapping, Sequence
 from contextlib import ExitStack
 from pathlib import Path
-from typing import Any, Literal
+from typing import Any, Literal, Dict
 
 from click import ClickException
+from openstack.image.v2.cache import Cache
 
 from .._settings import fragment_types as ft
 
@@ -58,6 +60,51 @@ class Config:
     ignore: list[str] | None = None
     issue_pattern: str = ""
 
+    @property
+    def section_display_names(self) -> list[str]:
+        return [x["display_name"] for x in self._section_data().values()]
+
+    def _section_data(self) -> Dict[str,Dict[str, Any]]:
+        primary_addition = "(primary)"
+        primary_exists = False
+        selections_sections = collections.OrderedDict()
+        nr_sections = len(self.sections)
+        paths_seen = set()
+        for section, path in self.sections.items():
+            display_name = section
+            if path in paths_seen:
+                raise ConfigError(f"Duplicate path '{path}' for section '{section}'")
+            paths_seen.add(path)
+            data = {
+                "display_name": display_name,
+                "path": path,
+            }
+
+            if section == "":
+                 display_name = "None"
+
+            if nr_sections == 1:
+                display_name = f"{display_name} {primary_addition}"
+
+            if data["path"] == "" and not primary_exists:
+                display_name = f"{display_name} {primary_addition}"
+                primary_exists = True
+
+            data["display_name"] = display_name
+            selections_sections[section] = data
+
+        if not primary_exists and nr_sections > 0:
+            first_item = selections_sections.popitem(last=False)
+            display_name = first_item["display_name"]
+            first_item.update({"display_name": f"{display_name} {primary_addition}"})
+
+        return selections_sections
+
+    def get_section_for_display_name(self, section_display_name: str) -> str|None:
+        for section, section_data in self._section_data().items():
+            if section_display_name == section_data["display_name"]:
+                return section
+        return None
 
     def check_issue_pattern(self, issue: str | None) -> bool|str:
         prompt = f"must match to {self.issue_pattern}"
@@ -69,6 +116,7 @@ def check_issue_pattern(self, issue: str | None) -> bool|str:
         else:
             return prompt
 
+
 class ConfigError(ClickException):
     def __init__(self, *args: str, **kwargs: str):
         self.failing_option = kwargs.get("failing_option")

src/towncrier/create.py

@@ -107,64 +107,39 @@ def __main(
         if ext.lower() in (".rst", ".md"):
             filename_ext = ext
 
-    section_provided = section is not None
-    if not section_provided:
-        # Get the default section.
-        if len(config.sections) == 1:
-            section = next(iter(config.sections))
+    if section is None:
+        if len(config.section_display_names) == 1:
+            section_display_name = config.section_display_names[0]
         else:
-            # If there are multiple sections then the first without a path is the default
-            # section, otherwise it's the first defined section.
-            for (
-                section_name,
-                section_dir,
-            ) in config.sections.items():  # pragma: no branch
-                if not section_dir:
-                    section = section_name
-                    break
-            if section is None:
-                section = list(config.sections.keys())[0]
+            section_display_name = questionary.select(
+                "Pick a section:",
+                choices=config.section_display_names
+            ).ask()
+        section = config.get_section_for_display_name(section_display_name)
+
+    if section.lower() == "none":
+        section = ""
 
     if section not in config.sections:
-        # Raise a click exception with the correct parameter.
-        section_param = None
-        for p in ctx.command.params:  # pragma: no branch
-            if p.name == "section":
-                section_param = p
-                break
-        expected_sections = ", ".join(f"'{s}'" for s in config.sections)
+        section_param = [x for x in ctx.command.params if x.name == "section"][0]
+        expected_sections = ", ".join(f"'{s}'" for s in config.section_display_names)
         raise click.BadParameter(
-            f"expected one of {expected_sections}",
+            f"'{section}' is not a valid section name, expected one of {expected_sections}",
             param=section_param,
         )
-    section = cast(str, section)
-
-    if not filename:
-        if not section_provided:
-            sections = list(config.sections)
-            if len(sections) > 1:
-                primary_addtion = "(primary)"
-                if len(sections) > 0:
-                    primary_addtion = f"NONE {primary_addtion}"
-                sections[0] = str(sections[0]) + primary_addtion
-                section = questionary.select(
-                    "Pick a section:",
-                    choices= sections
-                ).ask()
-                section = section.replace(primary_addtion, "")
-
-        issue = questionary.text(
-            "Issue number:",
-            validate = config.check_issue_pattern
-        ).ask()
-        fragment_type = questionary.select(
-            "Fragment type?",
-            choices= [type_name for type_name in config.types.keys()]
-        ).ask()
-
-        filename = f"{issue}.{fragment_type}"
-        if edit is None and content == DEFAULT_CONTENT:
-            edit = True
+
+    issue = questionary.text(
+        "Issue number:",
+        validate = config.check_issue_pattern
+    ).ask()
+    fragment_type = questionary.select(
+        "Fragment type:",
+        choices= [type_name for type_name in config.types.keys()]
+    ).ask()
+
+    filename = f"{issue}.{fragment_type}"
+    if edit is None and content == DEFAULT_CONTENT:
+        edit = True
 
     file_dir, file_basename = os.path.split(filename)
     if config.orphan_prefix and file_basename.startswith(f"{config.orphan_prefix}."):