Skip to content

Artifacts during the Upload test reports task during FMT have invalid names #188

@xShinnRyuu

Description

@xShinnRyuu

Task stack trace

Run actions/upload-artifact@v5
  with:
    name: test-reports-dotnet-8.0-redis-6.2-amazonlinux:latest-x64
    path: TestReport.html
  TestResults.trx
  failures.json
  valkey-glide/utils/clusters/**
  
    if-no-files-found: warn
    compression-level: 6
    overwrite: false
    include-hidden-files: false
  env:
    CARGO_TERM_COLOR: always
    IMAGE: amazonlinux-latest
    DOTNET_ROOT: /usr/share/dotnet
    CARGO_HOME: /github/home/.cargo
    CARGO_INCREMENTAL: 0
    SERVER_VERSION: 6.2
    SOURCES_VERSION: 6.2.1
`/usr/bin/docker exec  31a6d877aa4d8cae37bc9c57b4f708494eb2f2b7558771b2b4a4083fcc775685 sh -c "cat /etc/*release | grep ^ID"`
Multiple search paths detected. Calculating the least common ancestor of all paths
The least common ancestor is /__w/valkey-glide-csharp/valkey-glide-csharp. This will be the root directory of the artifact
With the provided path, there will be 371 files uploaded
Error: The artifact name is not valid: test-reports-dotnet-8.0-redis-6.2-amazonlinux:latest-x64. Contains the following character:  Colon :
          
Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n, Backslash \, Forward slash /
          
These characters are not allowed in the artifact name due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems.

Solution

We can resolve this by changing the naming convention of the artifact used for the Upload test reports task in .github/workflows/cd.yml

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions