Skip to content

Commit 72927e7

Browse files
committed
Stabilize payload bucket test
Signed-off-by: Yiwen Zhang <zhangyiwen1221@gmail.com>
1 parent 7c80b33 commit 72927e7

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

src/server.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1842,8 +1842,6 @@ struct valkeyServer {
18421842
long long stat_net_repl_output_bytes;
18431843
long long stat_net_cluster_slot_import_bytes; /* Bytes read from slot import sources. */
18441844
long long stat_net_cluster_slot_export_bytes; /* Bytes written to slot export sources. */
1845-
unsigned long long stat_request_payload_bytes_bucket[PAYLOAD_BUCKET_COUNT]; /* Per-command request size buckets. */
1846-
unsigned long long stat_reply_payload_bytes_bucket[PAYLOAD_BUCKET_COUNT]; /* Per-command reply size buckets. */
18471845
size_t stat_current_cow_peak; /* Peak size of copy on write bytes. */
18481846
size_t stat_current_cow_bytes; /* Copy on write bytes while child is active. */
18491847
monotime stat_current_cow_updated; /* Last update time of stat_current_cow_bytes */
@@ -1871,6 +1869,9 @@ struct valkeyServer {
18711869
long long stat_client_outbuf_limit_disconnections; /* Total number of clients reached output buf length limit */
18721870
long long stat_total_prefetch_entries; /* Total number of prefetched dict entries */
18731871
long long stat_total_prefetch_batches; /* Total number of prefetched batches */
1872+
/* Per-command payload size buckets (normal clients only). */
1873+
unsigned long long stat_request_payload_bytes_bucket[PAYLOAD_BUCKET_COUNT];
1874+
unsigned long long stat_reply_payload_bytes_bucket[PAYLOAD_BUCKET_COUNT];
18741875
/* The following two are used to track instantaneous metrics, like
18751876
* number of operations per second, network traffic. */
18761877
struct {

tests/unit/info.tcl

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,9 @@ start_server {tags {"info" "external:skip"}} {
588588
}
589589

590590
test {payload buckets: request and reply increments} {
591-
r config resetstat
591+
set c [valkey_client]
592+
$c ping
593+
$c config resetstat
592594
set sizes {32768 131072 524288 2097152 6291456}
593595
set req_fields {request_payload_bytes_bucket_lt_64kb
594596
request_payload_bytes_bucket_64kb_256kb
@@ -608,13 +610,13 @@ start_server {tags {"info" "external:skip"}} {
608610
set req_field [lindex $req_fields $i]
609611
set rep_field [lindex $rep_fields $i]
610612

611-
set info1 [r INFO stats]
613+
set info1 [$c INFO stats]
612614
set before_req [getInfoProperty $info1 $req_field]
613615
assert {[string is integer -strict $before_req]}
614616

615-
r set $key $val
617+
$c set $key $val
616618

617-
set info2 [r INFO stats]
619+
set info2 [$c INFO stats]
618620
set after_req [getInfoProperty $info2 $req_field]
619621
assert {[string is integer -strict $after_req]}
620622

@@ -627,9 +629,9 @@ start_server {tags {"info" "external:skip"}} {
627629
set before_rep [getInfoProperty $info2 $rep_field]
628630
assert {[string is integer -strict $before_rep]}
629631

630-
r get $key
632+
$c get $key
631633

632-
set info3 [r INFO stats]
634+
set info3 [$c INFO stats]
633635
set after_rep [getInfoProperty $info3 $rep_field]
634636
assert {[string is integer -strict $after_rep]}
635637

@@ -639,7 +641,9 @@ start_server {tags {"info" "external:skip"}} {
639641
assert_equal [expr {$before_rep + 1}] $after_rep
640642
}
641643

642-
r del $key
644+
$c del $key
643645
}
646+
647+
$c close
644648
}
645649
}

0 commit comments

Comments
 (0)