Skip to content

Commit 688e6f0

Browse files
authored
Merge branch 'verl-project:main' into main
2 parents cfc0d6e + 32705dc commit 688e6f0

File tree

153 files changed

+3666
-4673
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

153 files changed

+3666
-4673
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
/verl/workers/actor/megatron_actor.py @ISEEKYAN @vermouth1992
2121
/verl/workers/critic/megatron_critic.py @ISEEKYAN @vermouth1992
2222
/verl/workers/megatron_workers.py @ISEEKYAN @vermouth1992
23+
/verl/experimental @wuxibin89 @ArronHZG
2324

2425
/tests/single_controller @zw0610 @wuxibin89
2526
/tests/trainer @eric-haibin-lin @vermouth1992 @tongyx361 @PeterSH6

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
- [ ] Search for similar PRs. Paste at least one query link here: ...
88
- [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI)
9-
- `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`
9+
- `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`, `fully_async`, `one_step_off`
1010
- If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]`
1111
- `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
1212
- If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title.

.github/workflows/e2e_ascend.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,10 @@ jobs:
126126
ray stop --force
127127
export PYTHONPATH=$PYTHONPATH:/Megatron-LM
128128
USE_DIST_CKPT=True USE_DUMMY_MODEL=True DUMMY_MODEL_CONFIG_PATH=tests/special_e2e/ppo_trainer/expert_parallel/qwen3moe_minimal.json DUMMY_MODEL_PATH=$HOME/dist_ckpt/qwen3_30b_grpo_mindspeed bash tests/special_npu/run_qwen3_30b_grpo_mindspeed.sh
129+
- name: Running the E2E test with fully_async_policy algorithm (FSDP2)
130+
run: |
131+
ray stop --force
132+
bash tests/special_npu/run_fully_async_policy.sh
129133
130134
vlm_rl_job:
131135
if: github.repository_owner == 'verl-project'

.github/workflows/e2e_one_step_off_policy_ascend.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ on:
6868
# Entrypoints
6969
- ".github/workflows/e2e_one_step_off_policy_ascend.yml"
7070
- "examples/data_preprocess/gsm8k.py"
71-
- "tests/special_e2e/run_one_step_off_policy.sh"
71+
- "tests/special_npu/run_one_step_off_policy.sh"
7272

7373
# Cancel jobs on the same ref if a new one is triggered
7474
concurrency:
@@ -122,7 +122,7 @@ jobs:
122122
- name: Running the E2E test with one_step_off_policy algorithm (FSDP2)
123123
run: |
124124
ray stop --force
125-
bash tests/special_e2e/run_one_step_off_policy.sh
125+
bash tests/special_npu/run_one_step_off_policy.sh
126126
127127
# Test Megatron strategy
128128
e2e_one_step_off_policy_megatron_ascend:
@@ -167,4 +167,4 @@ jobs:
167167
run: |
168168
ray stop --force
169169
export PYTHONPATH=$PYTHONPATH:/Megatron-LM
170-
bash tests/special_e2e/run_one_step_off_policy.sh
170+
bash tests/special_npu/run_one_step_off_policy.sh

.github/workflows/e2e_sft_llm.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ jobs:
110110
- name: Prepare gsm8k dataset
111111
run: |
112112
ray stop --force
113-
python3 examples/data_preprocess/gsm8k.py --local_dataset_path ${HOME}/models/hf_data/gsm8k
113+
python3 examples/data_preprocess/gsm8k_multiturn_sft.py --local_dataset_path ${HOME}/models/hf_data/gsm8k
114114
- name: Running GSM8K E2E training tests on 8 L20 GPUs with rmpad using function rm
115115
run: |
116116
ray stop --force
@@ -123,10 +123,6 @@ jobs:
123123
run: |
124124
ray stop --force
125125
SP_SIZE=2 bash tests/special_e2e/sft/run_sft.sh
126-
- name: Check loss difference between sequence parallel vs. default implementation
127-
run: |
128-
ray stop --force
129-
ENTRYPOINT="tests/special_e2e/sft/test_sp_loss_match.py" SP_SIZE=2 bash tests/special_e2e/sft/run_sft.sh
130126
- name: Running GSM8K E2E training tests on 8 L20 GPUs with sequence parallism and liger
131127
run: |
132128
ray stop --force
@@ -140,10 +136,6 @@ jobs:
140136
ray stop --force
141137
LORA_RANK=32 RESUME_MODE=auto TOTAL_TRAIN_STEP=2 bash tests/special_e2e/sft/run_sft.sh
142138
# TODO: multiturn
143-
- name: Prepare gsm8k dataset
144-
run: |
145-
ray stop --force
146-
python3 examples/data_preprocess/gsm8k_multiturn_sft.py --local_dataset_path ${HOME}/models/hf_data/gsm8k
147139
- name: Running GSM8K E2E training tests with multiturn and various configs and compare results
148140
run: |
149141
bash tests/special_e2e/sft/test_sft_engine_all.sh

.github/workflows/e2e_sft_llm_ascend.yml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ jobs:
109109
ln -s /root/.cache/models ~/models
110110
- name: Prepare gsm8k dataset
111111
run: |
112-
python examples/data_preprocess/gsm8k.py --local_dataset_path ${HOME}/.cache/datasets/openai/gsm8k
112+
python3 examples/data_preprocess/gsm8k_multiturn_sft.py --local_dataset_path ${HOME}/.cache/datasets/openai/gsm8k
113113
- name: Running GSM8K E2E training tests on 8 NPUs with rmpad using function rm
114114
run: |
115115
ray stop --force
@@ -122,10 +122,6 @@ jobs:
122122
run: |
123123
ray stop --force
124124
SP_SIZE=2 bash tests/special_e2e/sft/run_sft.sh
125-
- name: Check loss difference between sequence parallel vs. default implementation
126-
run: |
127-
ray stop --force
128-
ENTRYPOINT="tests/special_e2e/sft/test_sp_loss_match.py" SP_SIZE=2 bash tests/special_e2e/sft/run_sft.sh
129125
- name: Running GSM8K E2E training tests with LoRA
130126
run: |
131127
ray stop --force
@@ -134,11 +130,6 @@ jobs:
134130
run: |
135131
ray stop --force
136132
LORA_RANK=32 RESUME_MODE=auto TOTAL_TRAIN_STEP=2 bash tests/special_e2e/sft/run_sft.sh
137-
# TODO: multiturn
138-
- name: Prepare gsm8k dataset
139-
run: |
140-
ray stop --force
141-
python3 examples/data_preprocess/gsm8k_multiturn_sft.py --local_dataset_path ${HOME}/.cache/datasets/openai/gsm8k
142133
- name: Running GSM8K E2E training tests with multiturn and various configs and compare results
143134
run: |
144135
export PYTHONPATH=$PYTHONPATH:/Megatron-LM

.github/workflows/gpu_unit_tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ jobs:
108108
pip3 install hf_transfer
109109
pip3 install -r requirements-test.txt
110110
pip3 install --no-deps -e .
111-
pip3 install cupy-cuda12x pytest-asyncio
111+
pip3 install cupy-cuda12x==13.6.0 pytest-asyncio
112112
pip3 install --ignore-installed blinker
113113
pip3 install --ignore-installed mlflow "numpy<2.0"
114114
- name: Run all GPU unit tests

.github/workflows/sgl.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ jobs:
113113
fetch-depth: 0
114114
- name: Install the current repository
115115
run: |
116-
pip3 install cupy-cuda12x pytest-asyncio
116+
pip3 install cupy-cuda12x==13.6.0 pytest-asyncio
117117
pip3 install hf_transfer fastmcp pytest-asyncio
118118
pip3 install -r requirements-test.txt
119119
pip3 install --no-deps -e .
@@ -144,7 +144,7 @@ jobs:
144144
fetch-depth: 0
145145
- name: Install the current repository
146146
run: |
147-
pip3 install cupy-cuda12x pytest-asyncio
147+
pip3 install cupy-cuda12x==13.6.0 pytest-asyncio
148148
pip3 install hf_transfer fastmcp pytest-asyncio
149149
pip3 install -r requirements-test.txt
150150
pip3 install --no-deps -e .

.github/workflows/vllm.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ jobs:
144144
fetch-depth: 0
145145
- name: Install the current repository
146146
run: |
147-
pip3 install cupy-cuda12x pytest-asyncio
147+
pip3 install pytest-asyncio
148148
pip3 install -r requirements-test.txt
149149
pip3 install --no-deps -e .
150150
pip3 install --upgrade "transformers<5.0"

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
**/playground
99
**/wandb
1010

11+
/pyrightconfig.json
12+
1113
# Byte-compiled / optimized / DLL files
1214
__pycache__/
1315
*.py[cod]

0 commit comments

Comments
 (0)