Skip to content

Commit d712137

Browse files
committed
[vllm] feat: add lora_as_adapter property to vLLMHttpServer for improved lora handling
1 parent c4ac00d commit d712137

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

verl/workers/rollout/vllm_rollout/vllm_async_server.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,12 @@ def get_server_address(self):
179179
"""Get http server address and port."""
180180
assert self._server_port is not None, "http server is not launched, port is None"
181181
return self._server_address, self._server_port
182+
183+
@property
184+
def lora_as_adapter(self) -> bool:
185+
return (
186+
self.model_config.lora_rank > 0 or self.model_config.lora.get("rank", 0) > 0
187+
) and not self.model_config.lora.get("merge", False)
182188

183189
async def collective_rpc(
184190
self,
@@ -543,9 +549,7 @@ async def generate(
543549

544550
# Add lora request
545551
lora_request = None
546-
if (
547-
self.model_config.lora_rank > 0 or self.model_config.lora.get("rank", 0) > 0
548-
) and not self.model_config.lora.get("merge", False):
552+
if self.lora_as_adapter:
549553
# Make sure we also check that the lora is already loaded in the engine
550554
lora_loaded = VLLM_LORA_INT_ID in await self.engine.list_loras()
551555
if lora_loaded:
@@ -619,10 +623,7 @@ async def sleep(self):
619623
if self.rollout_mode == RolloutMode.HYBRID:
620624
# Don't use engine.sleep(level=2) here
621625
# lora only update adapter weights, so set sleep level to 1
622-
lora_as_adapter = (
623-
self.model_config.lora_rank > 0 or self.model_config.lora.get("rank", 0) > 0
624-
) and not self.model_config.lora.get("merge", False)
625-
if lora_as_adapter:
626+
if self.lora_as_adapter:
626627
sleep_level = 1
627628
else:
628629
sleep_level = 2

0 commit comments

Comments
 (0)