Skip to content

Commit e129e9e

Browse files
committed
add dummy shutdown; add fields to NsightToolConfig
1 parent 7dbe100 commit e129e9e

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

verl/utils/profiler/config.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ class NsightToolConfig(BaseConfig):
2929

3030
"True for each task has its own database, False for all tasks in one training step share one database."
3131
discrete: bool = False
32+
controller_nsight_options: Optional[dict] = None
33+
worker_nsight_options: Optional[dict] = None
3234
name: str = "nsight"
3335

3436
def __post_init__(self) -> None:

verl/workers/rollout/sglang_rollout/async_sglang_server.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -421,6 +421,9 @@ async def stop_profile(self):
421421
):
422422
await self.tokenizer_manager.stop_profile()
423423

424+
async def shutdown(self):
425+
pass
426+
424427

425428
_rollout_worker_actor_cls = ray.remote(ServerAdapter)
426429

verl/workers/rollout/trtllm_rollout/trtllm_async_server.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -362,13 +362,11 @@ async def launch_servers(self):
362362
else f"trtllm_server_reward_{self.replica_rank}"
363363
)
364364

365-
if (
366-
"nsys" in self.profiler_config.global_tool_config
367-
and "worker_nsight_options" in self.profiler_config.global_tool_config["nsys"]
368-
):
369-
nsight_options = self.profiler_config.global_tool_config["nsys"]["worker_nsight_options"]
365+
if "nsys" in self.profiler_config.global_tool_config:
366+
nsight_options = self.profiler_config.global_tool_config["nsys"].worker_nsight_options
370367
else:
371-
nsight_options = {}
368+
nsight_options = None
369+
372370
server = TRTLLMHttpServer.options(
373371
scheduling_strategy=ray.util.scheduling_strategies.NodeAffinitySchedulingStrategy(
374372
node_id=node_id,

verl/workers/rollout/vllm_rollout/vllm_async_server.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -766,6 +766,8 @@ async def abort_request(self, request_id: str, reset_prefix_cache: bool = True)
766766
logger.error(f"Error aborting request {request_id}: {e}")
767767
return {"aborted": False, "request_id": request_id, "error": str(e)}
768768

769+
async def shutdown(self):
770+
pass
769771

770772
_rollout_worker_actor_cls = ray.remote(ServerAdapter)
771773

0 commit comments

Comments
 (0)