Skip to content

Commit ec908ea

Browse files
committed
fix: add bucket_size property with getter and setter
Signed-off-by: jianjunzhong <jianjunzhong@foxmail.com>
1 parent ec18f2b commit ec908ea

File tree

3 files changed

+21
-1
lines changed

3 files changed

+21
-1
lines changed

tests/checkpoint_engine/test_naive_correctness.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def init_config() -> DictConfig:
4343
config.trainer.nnodes = 1
4444
config.actor_rollout_ref.actor.use_dynamic_bsz = True
4545
config.actor_rollout_ref.model.path = os.path.expanduser("~/models/Qwen/Qwen3-VL-2B-Instruct")
46-
config.actor_rollout_ref.rollout.name = os.environ["ROLLOUT_NAME"]
46+
config.actor_rollout_ref.rollout.name = os.environ.get("ROLLOUT_NAME", "vllm")
4747
config.actor_rollout_ref.rollout.skip_tokenizer_init = False
4848
config.actor_rollout_ref.rollout.max_num_seqs = 256
4949
config.actor_rollout_ref.rollout.gpu_memory_utilization = 0.8

verl/checkpoint_engine/base.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -731,6 +731,16 @@ def __init__(self, bucket_size: int, is_master: bool = False) -> None:
731731
self.bucket_size = bucket_size
732732
self.is_master = is_master
733733

734+
@property
735+
def bucket_size(self) -> int:
736+
"""Return the bucket size in bytes."""
737+
return self._bucket_size
738+
739+
@bucket_size.setter
740+
def bucket_size(self, value: int):
741+
"""Set the bucket size in bytes."""
742+
self._bucket_size = value
743+
734744
def prepare(self):
735745
raise NotImplementedError
736746

verl/checkpoint_engine/kimi_checkpoint_engine.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,16 @@ def __init__(
245245
self.initialized = False
246246
self.checkpoint_name = "kimi_checkpoint_engine"
247247

248+
@property
249+
def bucket_size(self) -> int:
250+
"""Return the bucket size in bytes."""
251+
return self._bucket_size
252+
253+
@bucket_size.setter
254+
def bucket_size(self, value: int):
255+
"""Set the bucket size in bytes."""
256+
self._bucket_size = value
257+
248258
def prepare(self) -> MasterMetadata:
249259
if self.is_master:
250260
self.ip = ray.util.get_node_ip_address().strip("[]")

0 commit comments

Comments
 (0)