Skip to content

Merge pull request #282 from hxr-f/fix/inconsistent-morph-targets #130

Merge pull request #282 from hxr-f/fix/inconsistent-morph-targets

Merge pull request #282 from hxr-f/fix/inconsistent-morph-targets #130

Triggered via push June 28, 2025 09:04
Status Success
Total duration 3m 42s
Artifacts

TestCommit.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

30 warnings
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeType.cs#L17
Type '_RuntimeType' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L535
Type 'CSharpClassEmitter' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeField.cs#L17
Type '_RuntimeField' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeEnum.cs#L15
Type '_RuntimeEnum' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (macos-latest): build/SharpGLTF.CodeGen.Core/SchemaProcessing.cs#L58
Change return type of method '_Resolver' from 'NJsonSchema.JsonReferenceResolver' to 'SharpGLTF.SchemaProcessing.MyReferenceResolver' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
build (macos-latest): build/SharpGLTF.CodeGen.Core/SchemaReflection/SchemaTypesContext.cs#L66
Method UseBlittable passes parameter name 't' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (macos-latest): build/SharpGLTF.CodeGen.Core/SchemaDownload.cs#L12
Change the type of parameter 'remoteUrl' of method 'SchemaDownload.Syncronize(string, string)' from 'string' to 'System.Uri', or provide an overload to 'SchemaDownload.Syncronize(string, string)' that allows 'remoteUrl' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CodeEmitUtils.cs#L30
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L622
'string.Replace(string, string?)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'SharpGLTF.CodeGen.CSharpClassEmitter.AddFieldReflection(SharpGLTF.SchemaReflection.FieldInfo)' with a call to 'string.Replace(string, string?, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L27
Field 'CSharpEmitter._FieldsBrowsableState' is never assigned to, and will always have its default value
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/SchemaProcessing.cs#L110
Type 'MyReferenceResolver' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeEnum.cs#L15
Type '_RuntimeEnum' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeField.cs#L17
Type '_RuntimeField' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L535
Type 'CSharpClassEmitter' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/SchemaProcessing.cs#L58
Change return type of method '_Resolver' from 'NJsonSchema.JsonReferenceResolver' to 'SharpGLTF.SchemaProcessing.MyReferenceResolver' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/SchemaReflection/SchemaTypesContext.cs#L66
Method UseBlittable passes parameter name 't' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/SchemaDownload.cs#L12
Change the type of parameter 'remoteUrl' of method 'SchemaDownload.Syncronize(string, string)' from 'string' to 'System.Uri', or provide an overload to 'SchemaDownload.Syncronize(string, string)' that allows 'remoteUrl' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L622
'string.Replace(string, string?)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'SharpGLTF.CodeGen.CSharpClassEmitter.AddFieldReflection(SharpGLTF.SchemaReflection.FieldInfo)' with a call to 'string.Replace(string, string?, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CodeEmitUtils.cs#L30
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L27
Field 'CSharpEmitter._FieldsBrowsableState' is never assigned to, and will always have its default value
build (windows-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeField.cs#L17
Type '_RuntimeField' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (windows-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L535
Type 'CSharpClassEmitter' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (windows-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeEnum.cs#L15
Type '_RuntimeEnum' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (windows-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeType.cs#L17
Type '_RuntimeType' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (windows-latest): build/SharpGLTF.CodeGen.Core/SchemaReflection/SchemaTypesContext.cs#L66
Method UseBlittable passes parameter name 't' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (windows-latest): build/SharpGLTF.CodeGen.Core/SchemaProcessing.cs#L58
Change return type of method '_Resolver' from 'NJsonSchema.JsonReferenceResolver' to 'SharpGLTF.SchemaProcessing.MyReferenceResolver' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
build (windows-latest): build/SharpGLTF.CodeGen.Core/SchemaDownload.cs#L12
Change the type of parameter 'remoteUrl' of method 'SchemaDownload.Syncronize(string, string)' from 'string' to 'System.Uri', or provide an overload to 'SchemaDownload.Syncronize(string, string)' that allows 'remoteUrl' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
build (windows-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L622
'string.Replace(string, string?)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'SharpGLTF.CodeGen.CSharpClassEmitter.AddFieldReflection(SharpGLTF.SchemaReflection.FieldInfo)' with a call to 'string.Replace(string, string?, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
build (windows-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CodeEmitUtils.cs#L30
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
build (windows-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L27
Field 'CSharpEmitter._FieldsBrowsableState' is never assigned to, and will always have its default value