Skip to content

Commit c429533

Browse files
tasakchromium-wpt-export-bot
authored andcommitted
Revert "Implement the CSS image-animation property"
This reverts commit 0383d249f4843bcc19dbb6d201cc76d169c60cd7. Reason for revert: suspect causing blink_unittests failure on Linux UBSan Test. blink_unittests failed because of: - LayoutSelectionTest.TraverseLayoutObjectListStyleImage - LayoutTextCombineTest.ListItemStyleToImage - StyleResolverTest.CSSMarkerPseudoElement - UseCounterImplTest.CSSMarkerPseudoElementUA First build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/13361/ Original change's description: > Implement the CSS image-animation property > > Add support for the CSS image-animation property, which controls the > animated image playback. The property accepts three values: > > * normal: Default browser behavior > * running: Per-element timeline > * paused(tentative): Stop animated image > > Currently, image animations are managed by ImageAnimationController in > the CC layer. The controller manages the animation information, > including the next frame index and length, ...etc, via PaintImage's > stable_id as a key. > > The paint image has been created by BitmapImage::Draw and the image > shared the resource and paint image across the layout and styles if it > has same absolute URL by the WHATWG standard [1]. > > To pause, we should create new PaintImage with different paint id per > each style. > > Therefore, pass the image animation information to the > BitmapImage::Draw() to create different PaintImage by the style. The > BitmapImage class now caches multiple PaintImage instances, which are > keyed by DOM node ID and the animation state. This enables per-element > animation. > > Another approach is to duplicate the image resource manually. However, > this approach introduces another caching complexity on several layers. > Therefore, we will not pursue this approach. > > Removing "reftest-wait" does not capture the pixels at the exact time on the Mac and it will cause flakiness. Therefore, the exception of -running test suites on Mac has been added to TestExpectations. > > [1] https://html.spec.whatwg.org/multipage/rendering.html#images-3 > > Explainer: https://github.com/webplatformco/project-image-animation/tree/main/image-animation-property > Unofficial Draft: https://webplatform.design/projects/image-animation/image-animation-property/spec/overview > Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/0kUk5-6TAfM/m/7YVGLKzEBwAJ > Chromestatus Entry: https://chromestatus.com/feature/5078177326170112 > > > Bug: 429459566 > Change-Id: I6e5b6d6cccf6419c7c7c817a7082409e69a9c406 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7458159 > Reviewed-by: Anders Hartvoll Ruud <[email protected]> > Commit-Queue: Seokho Song <[email protected]> > Reviewed-by: Florin Malita <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1575651} Bug: 429459566 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ia26f9cef7a639659c289c50fae761fc412839e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7526465 Owners-Override: Takashi Sakamoto <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Auto-Submit: Takashi Sakamoto <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1575715}
1 parent 6dac99e commit c429533

9 files changed

+0
-142
lines changed

css/css-image-animation/image-animation-background-paused.tentative-ref.html

Lines changed: 0 additions & 10 deletions
This file was deleted.

css/css-image-animation/image-animation-background-paused.tentative.html

Lines changed: 0 additions & 29 deletions
This file was deleted.

css/css-image-animation/image-animation-img-paused.tentative-ref.html

Lines changed: 0 additions & 3 deletions
This file was deleted.

css/css-image-animation/image-animation-img-paused.tentative.html

Lines changed: 0 additions & 27 deletions
This file was deleted.

css/css-image-animation/image-animation-img-running-to-normal.tentative-ref.html

Lines changed: 0 additions & 3 deletions
This file was deleted.

css/css-image-animation/image-animation-img-running-to-normal.tentative.html

Lines changed: 0 additions & 33 deletions
This file was deleted.

css/css-image-animation/image-animation-img-running.tentative-ref.html

Lines changed: 0 additions & 3 deletions
This file was deleted.

css/css-image-animation/image-animation-img-running.tentative.html

Lines changed: 0 additions & 32 deletions
This file was deleted.

lint.ignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,6 @@ SET TIMEOUT: common/reftest-wait.js
157157
SET TIMEOUT: compute-pressure/resources/support-iframe.html
158158
SET TIMEOUT: conformance-checkers/*
159159
SET TIMEOUT: content-security-policy/*
160-
SET TIMEOUT: css/css-image-animation/image-animation-img-running.tentative.html
161-
SET TIMEOUT: css/css-image-animation/image-animation-img-running-to-normal.tentative.html
162160
SET TIMEOUT: css/compositing/opacity-and-transform-animation-crash.html
163161
SET TIMEOUT: css/css-contain/contain-body-overflow-002.html
164162
SET TIMEOUT: css/css-display/display-contents-shadow-dom-1.html

0 commit comments

Comments
 (0)