task: Add scripts for toggling local GutenbergKit development #25184
+108
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two scripts to simplify switching between local and remote GutenbergKit development: - gutenbergkit-local.sh: Switches Package.swift to use local path and enables GUTENBERG_EDITOR_URL in Jetpack scheme - gutenbergkit-remote.sh: Restores remote GitHub URL (version from trunk) and disables GUTENBERG_EDITOR_URL
Collaborator
Generated by 🚫 Danger |
dcalhoun
changed the title
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30673 | |
| Version | PR #25184 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 9dbe994 | |
| Installation URL | 7mrojnnca6sb8 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30673 | |
| Version | PR #25184 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 9dbe994 | |
| Installation URL | 62beuof437e68 |
- Check if already in target state and exit early - Verify expected patterns exist before attempting replacement - Verify changes were applied after sed operations
Update message to reflect that version is extracted from trunk, not git history.
Let users know that resolving package dependencies may take a while.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add two shell scripts to simplify switching between local and remote GutenbergKit development:
Scripts/gutenbergkit-local.sh: Switches Package.swift to use a local path (../../GutenbergKit) and enablesGUTENBERG_EDITOR_URLin the Jetpack schemeScripts/gutenbergkit-remote.sh: Restores the remote GitHub URL (version pulled from trunk) and disablesGUTENBERG_EDITOR_URLThese scripts aren't completely necessary, it's just something I do very frequently. If others do not feel this is worthwhile, we can discard these changes.
Testing instructions
./Scripts/gutenbergkit-local.shand verify:.package(path: "../../GutenbergKit")GUTENBERG_EDITOR_URLwithisEnabled = "YES"./Scripts/gutenbergkit-remote.shand verify:.package(url: "https://github.com/wordpress-mobile/GutenbergKit", from: "X.Y.Z")GUTENBERG_EDITOR_URLwithisEnabled = "NO"