fix: use lazy formatting for logging calls

Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>

Author: Millefeuille42

tests/storage/linstor/conftest.py

@@ -215,7 +215,7 @@ def get_vdi_host(path: str) -> Host:
         volume_name = get_vdi_volume_name_from_linstor()
         lv_path = f"/dev/{GROUP_NAME}/{volume_name}_00000"
         vdi_host = get_vdi_host(lv_path)
-        logging.info(f"[{host}]: corrupting `{lv_path}`")
+        logging.info("[%s]: corrupting `%s`", host, lv_path)
         vdi_host.ssh([
             "dd",
             "if=/dev/urandom",

tests/storage/linstor/test_linstor_sr.py

@@ -59,7 +59,7 @@ def test_create_and_destroy_sr(self, pool_with_linstor, provisioning_type, stora
 
 
 def get_drbd_status(host: Host, resource: str):
-    logging.debug(f"[{host}] Fetching DRBD status for resource `{resource}`...")
+    logging.debug("[%s] Fetching DRBD status for resource `%s`...", host, resource)
     return json.loads(host.ssh(["drbdsetup", "status", resource, "--json"]))
 
 def get_corrupted_resources(host: Host, resource: str):
@@ -76,7 +76,7 @@ def get_corrupted_resources(host: Host, resource: str):
     ]
 
 def wait_drbd_sync(host: Host, resource: str):
-    logging.info(f"[{host}] Waiting for DRBD sync on resource `{resource}`...")
+    logging.info("[%s] Waiting for DRBD sync on resource `%s`...", host, resource)
     host.ssh(["drbdadm", "wait-sync", resource])
 
 
@@ -131,22 +131,22 @@ def test_resynchronization(
                 for peer in conn.get("peer_devices", [])
                 if peer.get("peer-disk-state", "") == "UpToDate"
             )
-            logging.info(f"Elected `{other_host}` as peer for verification and repair")
+            logging.info("Elected `%s` as peer for verification and repair", other_host)
         except StopIteration:
             pytest.fail("Could not find an UpToDate peer host")
 
         corrupted = None
         max_attempts = 3
         # Attempting several times since testing revealed `drbdadm verify` can be flaky
         for attempt in range(1, max_attempts + 1):
-            logging.info(f"`drbdadm verify` attempt {attempt}/{max_attempts}")
-            logging.info(f"[{other_host}] Running DRBD verify for `{resource_name}`...")
+            logging.info("`drbdadm verify` attempt %d/%d", attempt, max_attempts)
+            logging.info("[%s] Running DRBD verify for %s...", other_host, resource_name)
             other_host.ssh(["drbdadm", "verify", f"{resource_name}:{hostname}/0"])
             wait_drbd_sync(other_host, resource_name)
 
             corrupted_resources = get_corrupted_resources(other_host, resource_name)
             if not corrupted_resources:
-                logging.warning(f"No corrupted resources found on attempt #{attempt}")
+                logging.warning("No corrupted resources found on attempt #%d", attempt)
                 continue
             for res_name, peer_name, out_of_sync in corrupted_resources:
                 if res_name == resource_name and peer_name == hostname:
@@ -156,7 +156,7 @@ def test_resynchronization(
         if not corrupted:
             pytest.fail(f"Failed to identify corrupted resource after {max_attempts} attempts")
 
-        logging.info(f"Invalidating remote resource `{resource_name}`...")
+        logging.info("Invalidating remote resource `%s`...", resource_name)
         other_host.ssh([
             "drbdadm", "invalidate-remote",
             f"{resource_name}:{hostname}/0",