enable and fix full prediction calculation

Author: ngc92

src/predict.cpp

@@ -220,9 +220,6 @@ int main(int argc, const char** argv) {
         std::cout << fmt::format("F1:           {:.3}%\n", percentage(tp, tp + (fp + fn) / 2));
 
     } else {
-        spdlog::error("Full predictions are currently not supported");
-        exit(1);
-        /*
         spdlog::info("Reading model file from '{}'", model_file);
         auto model = io::load_model(model_file);
 
@@ -234,8 +231,7 @@ int main(int argc, const char** argv) {
             std::exit(1);
         }
         const auto& predictions = task.get_predictions();
-        */
 
-        // TODO fix handling of full predictions
+        io::prediction::save_dense_predictions(result_file, predictions);
     }
 }

src/prediction/prediction.cpp

@@ -31,7 +31,7 @@ PredictionBase::PredictionBase(const DatasetBase* data,
     }
 }
 
-void PredictionBase::make_thread_local_features(int num_threads) {
+void PredictionBase::make_thread_local_features(long num_threads) {
     m_ThreadLocalFeatures.resize(num_threads);
 }
 
@@ -69,9 +69,12 @@ long FullPredictionTaskGenerator::num_tasks() const
 
 void FullPredictionTaskGenerator::run_tasks(long begin, long end, thread_id_t thread_id)
 {
-    do_prediction(begin, end, thread_id, m_Predictions.middleRows(begin, end));
+    do_prediction(begin, end, thread_id, m_Predictions.middleRows(begin, end - begin));
 }
 
+void FullPredictionTaskGenerator::prepare(long num_threads, long chunk_size) {
+    make_thread_local_features(num_threads);
+}
 
 
 TopKPredictionTaskGenerator::TopKPredictionTaskGenerator(const DatasetBase* data, std::shared_ptr<const Model> model, long K) :

src/prediction/prediction.h

@@ -40,7 +40,7 @@ namespace dismec::prediction {
         const DatasetBase* m_Data;              //!< Data on which the prediction is run
         std::shared_ptr<const Model> m_Model;   //!< Model (possibly partial) for which prediction is run
 
-        void make_thread_local_features(int num_threads);
+        void make_thread_local_features(long num_threads);
 
         void init_thread(thread_id_t thread_id) final;
 
@@ -70,6 +70,7 @@ namespace dismec::prediction {
 
         FullPredictionTaskGenerator(const DatasetBase* data, std::shared_ptr<const Model> model);
 
+        void prepare(long num_threads, long chunk_size) override;
         void run_tasks(long begin, long end, thread_id_t thread_id) override;
         [[nodiscard]] long num_tasks() const override;