chore: adjust constructor to match @yeoman/types (#1684)

Author: mshima

src/generator.ts

@@ -122,15 +122,28 @@ export class BaseGenerator<
    *   }
    * };
    */
-  constructor(options: O, features?: F);
-  constructor(args: string[], options: O, features?: F);
-
-  constructor(args: string[] | O, options: O | F, features?: F) {
+  constructor(args?: string[], options?: O, features?: F);
+  constructor(args?: string | string[] | O, options?: O | F, features?: F) {
     super();
 
-    const actualArgs: string[] = Array.isArray(args) ? args : [];
-    const actualOptions = Array.isArray(args) ? (options as O) : args;
-    const actualFeatures = Array.isArray(args) ? features : (options as F);
+    args = typeof args === 'string' ? [args] : args;
+
+    // Handle backward Compatibility
+    let actualArgs: string[];
+    let actualOptions: O;
+    let actualFeatures: F | undefined;
+    if (typeof features === 'object') {
+      actualArgs = args as string[];
+      actualOptions = options as O;
+      actualFeatures = features;
+    } else if (typeof args === 'object' && !Array.isArray(args)) {
+      actualArgs = [];
+      actualOptions = args as O;
+    } else {
+      actualArgs = args ?? [];
+      actualOptions = options as O;
+    }
+
     const { env, ...generatorOptions } = actualOptions;
 
     // Load parameters

src/index.ts

@@ -17,8 +17,6 @@ export default class Generator<
   _simpleGit?: SimpleGit;
 
   constructor(...args: any[]) {
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-expect-error
     super(...args);
 
     // eslint-disable-next-line @typescript-eslint/ban-ts-comment