-
Notifications
You must be signed in to change notification settings - Fork 69
Description
Hi, I would like to ask about the current restriction on backup_name when creating a backup.
When creating a backup, the backup_name allowing only letters, numbers, and underscores (_)
Currently, backup_name appears to follow the same naming restrictions as Milvus naming rules(https://milvus.io/docs/limitations.md#Naming-rules), which only allow letters, numbers, and underscores (_).
milvus-backup/core/backup/func.go
Lines 35 to 37 in 4b60c9d
| if validate.HasSpecialChar(name) { | |
| return errors.New("backup name should only contain numbers, letters and underscores") | |
| } |
However, in my use case, I want to generate a backup_name by combining milvus database name, collection name, and timestamp.
For example:
${db_name}-${collection_name}-${timestamp}
Allowing characters like the hyphen (-) would make it much easier to create a readable and structured backup_name.
But since backup_name is limited to only letters, numbers, and underscores (_), using such delimiters is currently not possible.
So I’d like to know, is this strict rule intentionally aligned with Milvus resource naming conventions?
Since backup_name eventually represents a storage path, would it be acceptable to allow a broader character set?
Would the project consider relaxing this constraint?
If this direction makes sense, I’d be happy to help contribute a PR to support it.
Thanks for your great work on this project!