Skip to content

feat: correct lo and behold, and jack-o'-lantern #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lukasmwerner wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat: correct lo and behold, and jack-o'-lantern #2185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8de00a7
feat: correct lo and behold
lukasmwerner Nov 13, 2025
85f0e1b
feat: correct jack-o-lantern
lukasmwerner Nov 13, 2025
150e0e4
fix: switch to phrase_set_corrections
lukasmwerner Nov 13, 2025
0152250
Merge branch 'master' into master
lukasmwerner Dec 20, 2025
d7c3c9b
Merge branch 'master' into master
elijah-potter Dec 22, 2025
c54985b
Merge branch 'master' into master
elijah-potter Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions harper-core/src/linting/phrase_corrections/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,6 +794,13 @@ pub fn lint_group() -> LintGroup {
"Corrects nonstandard variants of `low-hanging fruit`.",
LintKind::Usage
),
"LoAndBehold" => (
["low and behold"],
["lo and behold"],
"The correct form is `lo and behold`.",
"Corrects non-standard variant of `lo and behold`.",
LintKind::Malapropism
),
"ManagerialReins" => (
["managerial reigns"],
["managerial reins"],
Expand Down
16 changes: 16 additions & 0 deletions harper-core/src/linting/phrase_set_corrections/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,22 @@ pub fn lint_group() -> LintGroup {
"`Invest` is traditionally followed by 'in,' not `into.`",
LintKind::Usage
),
"JackOLantern" => (
&[
// Singular
("jack o lantern", "jack o'lantern"),
("jack olantern", "jack o'lantern"),
("jackolantern", "jack-o'-lantern"),
("jack-o-lantern", "jack-o'-lantern"),
// Plural
("jack o lanterns", "jack o'lanterns"),
("jack olantern", "jack o'lanterns"),
( "jackolanterns", "jack-o'-lanterns"),
( "jack-o-lanterns", "jack-o'-lanterns"),
],
"Use contraction when referring to `jack-o'-lantern`",
LintKind::Punctuation
),

// General litotes (double negatives) → direct positive suggestions
"LitotesDirectPositive" => (
Expand Down
Loading