chore: start working on issue 2044 #2442
Draft
+49
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#2044
Description
A basic skeleton started on the immigrate vs emigrate linter I started a month ago and put aside.
I'm turning this into a draft PR so that @Inhishonor can work on it.
I was still researching whether there were context where you could use either with both "to" and "from" like there are with "come" and "go".
Normally we "come from" one place and "go to" another. But we can also "go from one place to another".
I suspected similar things would work especially for "emigrate" and didn't want to make a too literal/too simplistic linter that just blindly replaced any verb+preposition pair without regard to context.
It also matches arbitrary prepositions after either verb to be able to spot things like "immigrate into" or people using the wrong preposition, which is a perennial common mistake.
(I'm not sure if this is the proper way to share or hand over a branch in git/GitHub so let me know!)
How Has This Been Tested?
Not yet at the testing stage.
Checklist