fix(harper-typst): condense contractions #2558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 23, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v1.4.1` → `v1.5.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v1.5.1`](https://github.com/Automattic/harper/releases/tag/v1.5.1) [Compare Source](Automattic/harper@v1.5.0...v1.5.1) #### What's Changed - fix(chrome-ext): problems with incorrect dialect selection and reversion by [@​elijah-potter](https://github.com/elijah-potter) in [#​2569](Automattic/harper#2569) **Full Changelog**: <Automattic/harper@v1.5.0...v1.5.1> ### [`v1.5.0`](https://github.com/Automattic/harper/releases/tag/v1.5.0) [Compare Source](Automattic/harper@v1.4.1...v1.5.0) #### What's Changed - feat(cli): Support all potential md extensions by [@​Inhishonor](https://github.com/Inhishonor) in [#​2449](Automattic/harper#2449) - fix: Allow exception `need to match` for `NeedToNoun` by [@​Greenheart](https://github.com/Greenheart) in [#​2448](Automattic/harper#2448) - feat: initiatively→proactively / initially by [@​hippietrail](https://github.com/hippietrail) in [#​2432](Automattic/harper#2432) - fix: propagate proper noun property to possessive forms by [@​hippietrail](https://github.com/hippietrail) in [#​2399](Automattic/harper#2399) - chore: +vibe coding terms; add `/` annotation for phrasal verbs by [@​hippietrail](https://github.com/hippietrail) in [#​2452](Automattic/harper#2452) - Add some political science terms to the dictionary by [@​Inhishonor](https://github.com/Inhishonor) in [#​2441](Automattic/harper#2441) - feat: number agreement in this/these type(s) of thing(s) by [@​hippietrail](https://github.com/hippietrail) in [#​2400](Automattic/harper#2400) - build(deps): bump serde\_json from 1.0.148 to 1.0.149 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2467](Automattic/harper#2467) - fix(core): don't replace non-alphabetic characters when title-casing by [@​elijah-potter](https://github.com/elijah-potter) in [#​2454](Automattic/harper#2454) - `harper-cli lint` keep overlapping lints switch & show lint priorities by [@​hippietrail](https://github.com/hippietrail) in [#​2435](Automattic/harper#2435) - feat: imho→in my humble/honest opinion by [@​hippietrail](https://github.com/hippietrail) in [#​2468](Automattic/harper#2468) - feat(core): create the Weir language by [@​elijah-potter](https://github.com/elijah-potter) in [#​2357](Automattic/harper#2357) - chore: add "discoverable", "handoff" by [@​hippietrail](https://github.com/hippietrail) in [#​2457](Automattic/harper#2457) - refactor(core): merge semantically identical funcs by [@​86xsk](https://github.com/86xsk) in [#​2458](Automattic/harper#2458) - doc: clarify instructions and project status by [@​elijah-potter](https://github.com/elijah-potter) in [#​2453](Automattic/harper#2453) - feat: Add get\_rel() to get a token relative to the end of a slice by [@​hippietrail](https://github.com/hippietrail) in [#​2461](Automattic/harper#2461) - chore: add "different tact" to "change tacts" linter by [@​hippietrail](https://github.com/hippietrail) in [#​2469](Automattic/harper#2469) - feat: create `harper-thesaurus` by [@​86xsk](https://github.com/86xsk) in [#​2085](Automattic/harper#2085) - fix(core): MR getting flagged as 'misspelled' by [@​elijah-potter](https://github.com/elijah-potter) in [#​2476](Automattic/harper#2476) - feat: Make the dialect indicator in the VS Code status bar clickable to change dialect by [@​hippietrail](https://github.com/hippietrail) in [#​2443](Automattic/harper#2443) - fix(core): ignore apostrophes in the `OrthographicConsistency` rule by [@​elijah-potter](https://github.com/elijah-potter) in [#​2475](Automattic/harper#2475) - fix(chrome-ext): highlights are mis-positioned in fixed elements by [@​elijah-potter](https://github.com/elijah-potter) in [#​2477](Automattic/harper#2477) - feat: take a look to → take a look at by [@​hippietrail](https://github.com/hippietrail) in [#​2478](Automattic/harper#2478) - feat: better of with → better off with by [@​hippietrail](https://github.com/hippietrail) in [#​2483](Automattic/harper#2483) - doc(core): describe how Weir's replacement strategies work by [@​elijah-potter](https://github.com/elijah-potter) in [#​2480](Automattic/harper#2480) - fix: don't flag "no two" etc. by [@​hippietrail](https://github.com/hippietrail) in [#​2489](Automattic/harper#2489) - feat: very less → much less/far less/a lot less by [@​hippietrail](https://github.com/hippietrail) in [#​2484](Automattic/harper#2484) - feat: more fast → faster etc. by [@​hippietrail](https://github.com/hippietrail) in [#​2263](Automattic/harper#2263) - Hotkey by [@​LoganBrinsmead](https://github.com/LoganBrinsmead) in [#​2149](Automattic/harper#2149) - feat: fix "I walks" / "he walk" etc. by [@​hippietrail](https://github.com/hippietrail) in [#​2333](Automattic/harper#2333) - perf(test): improve test performance by [@​86xsk](https://github.com/86xsk) in [#​2473](Automattic/harper#2473) - fix(core): panics in Weir by [@​elijah-potter](https://github.com/elijah-potter) in [#​2493](Automattic/harper#2493) - fix(thesaurus): MacOS builds by using `ruzstd` by [@​elijah-potter](https://github.com/elijah-potter) in [#​2490](Automattic/harper#2490) - build(deps): bump chrono from 0.4.42 to 0.4.43 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2535](Automattic/harper#2535) - build(deps): bump thiserror from 2.0.17 to 2.0.18 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2533](Automattic/harper#2533) - build(deps): bump indexmap from 2.12.1 to 2.13.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2534](Automattic/harper#2534) - Indian English tweaks by [@​hippietrail](https://github.com/hippietrail) in [#​2507](Automattic/harper#2507) - fix(core): fix `AnA` false-positives by [@​86xsk](https://github.com/86xsk) in [#​2538](Automattic/harper#2538) - feat: whom → who when subject of verb by [@​hippietrail](https://github.com/hippietrail) in [#​2528](Automattic/harper#2528) - feat: obsess on → obsess over; obsessed on → obsessed with by [@​hippietrail](https://github.com/hippietrail) in [#​2537](Automattic/harper#2537) - feat: vicious circle vs cycle by [@​hippietrail](https://github.com/hippietrail) in [#​2384](Automattic/harper#2384) - fix(core): capitalization issue in `SpellCheck` by [@​86xsk](https://github.com/86xsk) in [#​2541](Automattic/harper#2541) - feat: despite it is→ despite (it/its) being by [@​hippietrail](https://github.com/hippietrail) in [#​2542](Automattic/harper#2542) - feat: detect browser dialect by [@​hippietrail](https://github.com/hippietrail) in [#​2485](Automattic/harper#2485) - feat: to loose/too lose→too loose/to lose by [@​hippietrail](https://github.com/hippietrail) in [#​2543](Automattic/harper#2543) - feat: allow any preposition, special plurals for both nouns by [@​hippietrail](https://github.com/hippietrail) in [#​2514](Automattic/harper#2514) - fix(chrome-ext): Applying suggestions breaks cursor/keyboard in Draft.js and Slate editors by [@​draphy](https://github.com/draphy) in [#​2495](Automattic/harper#2495) - feat(cli): chunk annotations by [@​86xsk](https://github.com/86xsk) in [#​2450](Automattic/harper#2450) - fix(core): allow both a/an for "LED" in `AnA` by [@​86xsk](https://github.com/86xsk) in [#​2556](Automattic/harper#2556) - refactor(core): simplify code by [@​86xsk](https://github.com/86xsk) in [#​2555](Automattic/harper#2555) - feat(core): create a good number of new Weir rules by [@​elijah-potter](https://github.com/elijah-potter) in [#​2506](Automattic/harper#2506) - feat(harper.js): expose the Typst parser in `harper.js` by [@​elijah-potter](https://github.com/elijah-potter) in [#​2554](Automattic/harper#2554) - docs: fix errors in documentation by [@​elijah-potter](https://github.com/elijah-potter) in [#​2557](Automattic/harper#2557) - fix(chrome-ext): Applying suggestions duplicates text in WhatsApp Web Lexical editor by [@​draphy](https://github.com/draphy) in [#​2563](Automattic/harper#2563) - fix(harper-typst): condense contractions by [@​elijah-potter](https://github.com/elijah-potter) in [#​2558](Automattic/harper#2558) - chore: dictionary curation by [@​hippietrail](https://github.com/hippietrail) in [#​2496](Automattic/harper#2496) - chore: Update dictionary with new entries by [@​Inhishonor](https://github.com/Inhishonor) in [#​2540](Automattic/harper#2540) - refactor(core): remove dependency on `lazy_static` by [@​86xsk](https://github.com/86xsk) in [#​2560](Automattic/harper#2560) - feat(harper-typst): update to Typst `0.14.2` by [@​elijah-potter](https://github.com/elijah-potter) in [#​2566](Automattic/harper#2566) - fix(chrome-ext): remove mention of Chrome Extension to avoid confusion for Firefox users by [@​elijah-potter](https://github.com/elijah-potter) in [#​2567](Automattic/harper#2567) #### New Contributors - [@​Inhishonor](https://github.com/Inhishonor) made their first contribution in [#​2449](Automattic/harper#2449) - [@​Greenheart](https://github.com/Greenheart) made their first contribution in [#​2448](Automattic/harper#2448) - [@​draphy](https://github.com/draphy) made their first contribution in [#​2495](Automattic/harper#2495) **Full Changelog**: <Automattic/harper@v1.4.1...v1.5.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi44OC4yIiwidXBkYXRlZEluVmVyIjoiNDIuODguMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6Om1pbm9yIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This PR resolves an issue brought to me by @lukasmwerner.
Description
When linting a Typst file, Harper would erroneously parse contractions (like
doesn't) as two separate words. This would result in lint noise from the spell checker.To fix this, I've modified the parser to condense WORD APOSTROPHE WORD sequences into single words.
How Has This Been Tested?
Additional integration test.
Checklist