Skip to content

Conversation

@manzoorwanijk
Copy link
Member

Completes SOCIAL-321

Proposed changes:

Refactors the share status component to use WordPress core Notice component for better accessibility and consistent styling.

  • Wraps status messages (success, warning, in-progress) in Notice component with appropriate status prop
  • Adds aria-hidden="true" to the celebration emoji to prevent screen readers from announcing it
  • Removes redundant margin-top from resharing panel styles
  • Keeps the loading state unchanged since a snackbar already announces sharing progress to screen readers

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  1. Open a post in the editor and share it to social media
  2. Verify the share status messages display with proper Notice styling
  3. Test with a screen reader to confirm the notices are announced
  4. Check both the post-publish panel and the resharing panel for correct styling
BEFORE AFTER
Screenshot 2026-01-20 at 2 05 46 PM Screenshot 2026-01-20 at 2 01 44 PM
Screenshot 2026-01-20 at 2 06 57 PM Screenshot 2026-01-20 at 2 02 04 PM
Screenshot 2026-01-20 at 2 06 12 PM Screenshot 2026-01-20 at 2 08 27 PM
No difference
Screenshot 2026-01-20 at 2 05 15 PM Screenshot 2026-01-20 at 1 53 51 PM
Screenshot 2026-01-20 at 1 53 16 PM Screenshot 2026-01-20 at 1 53 16 PM

@manzoorwanijk manzoorwanijk requested a review from a team January 20, 2026 08:52
@manzoorwanijk manzoorwanijk self-assigned this Jan 20, 2026
Copilot AI review requested due to automatic review settings January 20, 2026 08:52
@manzoorwanijk manzoorwanijk added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Jan 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/social-sharestatus-use-core-notice branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/social-sharestatus-use-core-notice

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin labels Jan 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: February 3, 2026
    • Code freeze: February 3, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Social plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the share status component to use WordPress core's Notice component, improving accessibility and ensuring consistent UI styling across different status messages.

Changes:

  • Wraps share status messages in the Notice component with appropriate status props (success, warning, or default)
  • Adds aria-hidden="true" to the celebration emoji to prevent screen readers from announcing decorative content
  • Removes redundant margin-top from the resharing panel styles
  • Adds explanatory comment for why the loading state doesn't use the Notice component

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
projects/plugins/social/changelog/update-social-sharestatus-use-core-notice Changelog entry documenting the UI refactoring
projects/plugins/jetpack/changelog/update-social-sharestatus-use-core-notice Changelog entry for Jetpack plugin
projects/packages/publicize/changelog/update-social-sharestatus-use-core-notice Changelog entry for publicize package
projects/packages/publicize/_inc/components/resharing-panel/styles.module.scss Removes redundant margin-top styling
projects/packages/publicize/_inc/components/post-publish-share-status/share-status.tsx Refactors status messages to use Notice component and improves accessibility

@jp-launch-control
Copy link

jp-launch-control bot commented Jan 20, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Updated the ShareStatus component to display sharing status messages using the Notice component for improved accessibility and consistency. Also removed unnecessary margin from the resharing panel styles.
@manzoorwanijk manzoorwanijk force-pushed the update/social-sharestatus-use-core-notice branch from db4b31e to 36c93d2 Compare January 20, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin [Status] Needs Team Review Obsolete. Use Needs Review instead. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants