-
Notifications
You must be signed in to change notification settings - Fork 854
Forms: wp build dashboard - make spam and trash note dynamic #46888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Forms responses single-response view to make the spam/trash retention copy i18n‑friendly and aligned with backend configuration, and to apply the shared tip styling used elsewhere in the dashboard.
Changes:
- Import and use
useConfigValueto reademptyTrashDaysso the trash retention message reflects the configured backend value. - Update the spam and trash tip copy to use
_n+sprintffor proper pluralization and interpolation, and align the markup with the shared.jp-forms__inbox__tip-containerstyles. - Add a changelog entry describing the behavioral and styling update for the response sidebar tips.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
projects/packages/forms/routes/responses/response/index.tsx |
Uses useConfigValue('emptyTrashDays') and _n/sprintf to render localized, dynamic trash/spam retention messages, and switches the tips container to the shared .jp-forms__inbox__tip-container styling. |
projects/packages/forms/changelog/fix-forms-response-tip-styles |
Adds a changelog entry describing the dynamic spam/trash tip behavior and styling change for the Forms responses sidebar. |
| Significance: patch | ||
| Type: changed | ||
|
|
||
| Use dynamic number values for spam and trash tip in response sidebar, and add styles. |
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry description is missing a component/feature prefix even though the change is specific to the Forms responses dashboard (for example, you could use a prefix like "Responses:" at the start of the sentence). This helps keep changelog entries consistent and immediately scannable across the monorepo.
| Use dynamic number values for spam and trash tip in response sidebar, and add styles. | |
| Responses: Show dynamic counts for spam and trash tips in the responses sidebar, and improve styles. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
7233d9b to
a26acc3
Compare
a26acc3 to
d2a75d0
Compare
Proposed changes:
Some spacing styles need adjusting but now the new and old dash sidebars share the same style, I'll separate them in a follow-up.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
jetpack build package/formsadd_filter('jetpack_forms_alpha', '__return_true');