Skip to content

Conversation

@simison
Copy link
Member

@simison simison commented Feb 2, 2026

Proposed changes:

  • Dynamic number values for both trash and spam;
    • Spam for better conforming i18n translation rules
    • Trash because the number of days is configured at the backend by the user
  • Add styles (styles are already loaded, but class was missing)

Some spacing styles need adjusting but now the new and old dash sidebars share the same style, I'll separate them in a follow-up.

Screenshot 2026-02-02 at 11 35 40 Screenshot 2026-02-02 at 11 35 52

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Build forms jetpack build package/forms
  • Enable dashboard with add_filter('jetpack_forms_alpha', '__return_true');
  • Test new wp build dashboard response sidebar for spam and trash folders

Copilot AI review requested due to automatic review settings February 2, 2026 09:34
@simison simison added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Package] Forms Enhancement labels Feb 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-wp-build-spam-trash-note branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-wp-build-spam-trash-note

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Forms responses single-response view to make the spam/trash retention copy i18n‑friendly and aligned with backend configuration, and to apply the shared tip styling used elsewhere in the dashboard.

Changes:

  • Import and use useConfigValue to read emptyTrashDays so the trash retention message reflects the configured backend value.
  • Update the spam and trash tip copy to use _n + sprintf for proper pluralization and interpolation, and align the markup with the shared .jp-forms__inbox__tip-container styles.
  • Add a changelog entry describing the behavioral and styling update for the response sidebar tips.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
projects/packages/forms/routes/responses/response/index.tsx Uses useConfigValue('emptyTrashDays') and _n/sprintf to render localized, dynamic trash/spam retention messages, and switches the tips container to the shared .jp-forms__inbox__tip-container styling.
projects/packages/forms/changelog/fix-forms-response-tip-styles Adds a changelog entry describing the dynamic spam/trash tip behavior and styling change for the Forms responses sidebar.

Significance: patch
Type: changed

Use dynamic number values for spam and trash tip in response sidebar, and add styles.
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry description is missing a component/feature prefix even though the change is specific to the Forms responses dashboard (for example, you could use a prefix like "Responses:" at the start of the sentence). This helps keep changelog entries consistent and immediately scannable across the monorepo.

Suggested change
Use dynamic number values for spam and trash tip in response sidebar, and add styles.
Responses: Show dynamic counts for spam and trash tips in the responses sidebar, and improve styles.

Copilot uses AI. Check for mistakes.
@jp-launch-control
Copy link

jp-launch-control bot commented Feb 2, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@simison simison changed the title Forms: wp build dsahboard, make spam and trash note dynamic Forms: wp build dashboard - make spam and trash note dynamic Feb 2, 2026
@simison simison force-pushed the update/forms-wp-build-spam-trash-note branch from 7233d9b to a26acc3 Compare February 2, 2026 19:53
@simison simison force-pushed the update/forms-wp-build-spam-trash-note branch from a26acc3 to d2a75d0 Compare February 3, 2026 10:05
@simison simison merged commit 242c372 into trunk Feb 3, 2026
70 checks passed
@simison simison deleted the update/forms-wp-build-spam-trash-note branch February 3, 2026 10:53
@github-actions github-actions bot added [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed [Status] Needs Review This PR is ready for review. labels Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement [Feature] Contact Form [Package] Forms [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants