-
Notifications
You must be signed in to change notification settings - Fork 853
Social: Adjust connection toggle UI and remove redundant "Preview" heading #46889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social: Adjust connection toggle UI and remove redundant "Preview" heading #46889
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the Social Preview modal UI by improving visual consistency through styling adjustments and removing redundant visual elements while maintaining accessibility.
Changes:
- Made the "Preview" heading visually hidden (but still accessible to screen readers) to reduce visual redundancy
- Added gray background to the connection toggle wrapper to create visual cohesion with the preview section below
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/packages/publicize/changelog/update-social-adjust-connection-toggle-and-preview-heading | Adds changelog entry documenting the UI improvements |
| projects/packages/publicize/_inc/components/customize-and-preview/tab-panels/styles.module.scss | Adds background color and removes bottom padding from connection toggle wrapper to visually connect it with preview section |
| projects/packages/publicize/_inc/components/customize-and-preview/preview-section/styles.module.scss | Removes h2 styling that is no longer needed since heading is now visually hidden |
| projects/packages/publicize/_inc/components/customize-and-preview/preview-section/index.tsx | Wraps "Preview" heading with VisuallyHidden component to maintain accessibility while hiding it visually |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
gmjuhasz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview heading is removed now visually, while keeping accessibility
Fixes SOCIAL-350, SOCIAL-351
Proposed changes:
This PR improves the visual consistency of the Social Preview modal by adjusting the connection toggle styling and removing redundant UI elements.
Changes:
Remove redundant "Preview" heading: The "Preview" heading inside the preview section is now visually hidden (still accessible to screen readers) since it's redundant when the user has already clicked the "Preview" tab
Adjust connection toggle UI: Added background color (
gray-100) to the connection toggle wrapper to visually connect it with the preview section below, creating a more cohesive appearanceCenter align preview: Adjusted the styling for preview to make it always center-aligned - both vertically and horizontally.
Other information:
Jetpack product discussion
SOCIAL-350
Does this pull request change what data or activity we track or use?
No changes to data tracking.
Testing instructions:
add_blog_sticker( 'jetpack-social-unified-ui-v1', null, null, <your-blog-id> );Create or edit a post with Jetpack Social connections configured
Open the Social preview modal
Verify:
Remove the featured image from the post and any custom media from the customizations
Confirm that the preview is center-aligned
Screenshots