Skip to content

Conversation

@manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Feb 2, 2026

Fixes SOCIAL-343

Proposed changes:

This PR improves the upgrade flow by opening upgrade and demo links in a new tab instead of navigating away from the editor.

Changes:

  • Open links in new tab: Upgrade and demo buttons now open in a new tab (target="_blank"), preserving the editor context so users don't lose their work
  • Convert buttons to links: Changed from using useAutosaveAndRedirect (which navigates away) to standard link buttons with proper href attributes
  • Render buttons manually: Replaced the Notice actions prop with manually rendered buttons using Flex layout, as the actions prop doesn't support all necessary button props (see Gutenberg issue #74090)
  • Simplify code: Removed unused useAutosaveAndRedirect hook, clsx import, and custom styles

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

SOCIAL-343

Does this pull request change what data or activity we track or use?

No changes to data tracking.

Testing instructions:

  • Create or edit a post as a user without a paid Jetpack Social plan

  • Open the Jetpack Social panel in the editor sidebar

  • Click the "Upgrade now" button in the upgrade notice

  • Verify: The upgrade page opens in a new tab, and your editor remains open with unsaved changes preserved

  • Click the "View demo" button

  • Verify: The demo page opens in a new tab and scrolls to the video on the social landing page

  • Test both upgrade notices:

    • The general upgrade notice (in the Social panel)
    • The customization upgrade notice in the preview modal
  • Sidebar
    Screenshot 2026-02-02 at 4 55 09 PM

  • Preview modal
    image

@manzoorwanijk manzoorwanijk requested a review from a team February 2, 2026 11:27
@manzoorwanijk manzoorwanijk self-assigned this Feb 2, 2026
Copilot AI review requested due to automatic review settings February 2, 2026 11:27
@manzoorwanijk manzoorwanijk added the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Feb 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/social/improve-upgrade-buttons branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/social/improve-upgrade-buttons

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize labels Feb 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Jetpack Social upgrade notices so the “Upgrade now” and “View demo” CTAs open in a new tab, keeping the block editor session intact.

Changes:

  • Replace Notice actions usage with manually rendered link-style Button components using href, target="_blank", and rel.
  • Remove autosave-and-redirect behavior and related styling that supported the old actions layout.
  • Add a Publicize package changelog entry for the behavior change.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
projects/packages/publicize/changelog/update-social-improve-upgrade-buttons Adds changelog entry documenting the upgrade/demo CTA behavior change.
projects/packages/publicize/_inc/components/form/upgrade-notice.tsx Renders upgrade + demo CTAs as links opening in a new tab within the notice body.
projects/packages/publicize/_inc/components/form/upgrade-notice-customization.tsx Renders customization upgrade CTA as a link opening in a new tab; removes notice action styling usage.
projects/packages/publicize/_inc/components/form/styles.module.scss Removes now-unused customization notice action styling.

@jp-launch-control
Copy link

jp-launch-control bot commented Feb 2, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking either the demo or considering upgrade, it opens in a new tab 👍

CleanShot.2026-02-02.at.12.48.07.mp4

@manzoorwanijk manzoorwanijk merged commit 15d0b7d into trunk Feb 2, 2026
78 checks passed
@manzoorwanijk manzoorwanijk deleted the update/social/improve-upgrade-buttons branch February 2, 2026 11:58
@github-actions github-actions bot added [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants