-
Notifications
You must be signed in to change notification settings - Fork 267
Add retry mechanism to flaky ManifestGen test #6545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The test for dotnet run --publisher manifest can be flaky on macOS/Linux runners. Added a retry mechanism (3 retries with 2 second intervals) to make the test more resilient to intermittent failures. Co-authored-by: JeffreyCA <[email protected]>
Co-authored-by: JeffreyCA <[email protected]>
Co-authored-by: JeffreyCA <[email protected]>
|
/azp run azure-dev - cli |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp help |
Supported commands
See additional documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a retry mechanism to the flaky Test_CLI_Aspire_DetectGen/ManifestGen test that fails intermittently on Linux/Mac runners due to transient dotnet command failures.
Changes:
- Wraps the
PublishAppHostManifestcall in a retry loop with 3 attempts and 2-second intervals - Adds logging for retry attempts to aid debugging
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
|
/check-enforcer override |
Test_CLI_Aspire_DetectGen/ManifestGenfails intermittently on Linux/Mac runners due to transientdotnet run --publisher manifestfailures.Changes
PublishAppHostManifestcall in retry loop (3 retries, 2s intervals)Uses existing
go-retrylibrary already in use across the test suite (cli_test.go,up_test.go).Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.