-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[TSP Conversion][serialconsole] TypeSpec conversion #39700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
643f031 to
ec2017a
Compare
| /** | ||
| * Handles requests to list all SerialPort resources in a subscription. | ||
| */ | ||
| listBySubscriptions is ArmListBySubscription< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not paging operation in previous swagger. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/serialconsole/resource-manager/Microsoft.SerialConsole/SerialConsole/stable/2024-07-01/serialport.json#L208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
0d65d50 to
1919855
Compare
733899b to
03b60aa
Compare
03b60aa to
028b3f0
Compare
Issue/Diff:
ListOperationsdoesn't haveApiVersionParameter, in new swagger it has.