Skip to content

Conversation

@cxznmhdcxz
Copy link
Member

@cxznmhdcxz cxznmhdcxz commented Jan 16, 2026

Issue/Diff:

  1. In old swagger ListOperations doesn't have ApiVersionParameter, in new swagger it has.
  2. Currently this service doesn't exist in SDK for java

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added resource-manager TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Jan 16, 2026
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.SerialConsole-SerialConsole
TypeSpec Microsoft.SerialConsole
Go sdk/resourcemanager/serialconsole/armserialconsole
JavaScript @azure/arm-serialconsole
Python azure-mgmt-serialconsole

@cxznmhdcxz cxznmhdcxz force-pushed the ruih/serialconsole-tsp-convert branch from 643f031 to ec2017a Compare January 16, 2026 03:21
@github-actions github-actions bot added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required and removed VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Jan 16, 2026
@cxznmhdcxz cxznmhdcxz changed the title [TSP Migration][serialconsole] TypeSpec migrate [TSP Migration][serialconsole] TypeSpec conversion Jan 16, 2026
/**
* Handles requests to list all SerialPort resources in a subscription.
*/
listBySubscriptions is ArmListBySubscription<
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@cxznmhdcxz cxznmhdcxz force-pushed the ruih/serialconsole-tsp-convert branch from 0d65d50 to 1919855 Compare January 16, 2026 09:24
@cxznmhdcxz cxznmhdcxz force-pushed the ruih/serialconsole-tsp-convert branch from 733899b to 03b60aa Compare January 19, 2026 03:09
@cxznmhdcxz cxznmhdcxz force-pushed the ruih/serialconsole-tsp-convert branch from 03b60aa to 028b3f0 Compare January 19, 2026 03:20
@cxznmhdcxz cxznmhdcxz changed the title [TSP Migration][serialconsole] TypeSpec conversion [TSP Conversion][serialconsole] TypeSpec conversion Jan 19, 2026
@cxznmhdcxz cxznmhdcxz marked this pull request as ready for review January 19, 2026 05:04
@cxznmhdcxz cxznmhdcxz marked this pull request as draft January 19, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BreakingChange-Go-Sdk BreakingChange-JavaScript-Sdk BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants