Skip to content

Conversation

@skywing918 skywing918 requested a review from lirenhe as a code owner January 23, 2026 09:57
Copilot AI review requested due to automatic review settings January 23, 2026 09:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds new documentation sources to the Azure SDK QA bot knowledge sync configuration. It references two repositories containing OpenAPI Diff (OAD) rules documentation to enhance the bot's knowledge base about breaking changes and API diff rules.

Changes:

  • Added azure-rest-api-specs repository configuration to sync the BreakingChange-Oad-Rules-Mapping.md document
  • Added openapi-diff repository configuration to sync OAD rules documentation from the /docs directory

},
"paths": [
{
"description": "Azure REST API Breaking Change And Oad Rules Mapping",
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description has inconsistent capitalization. "And" should be lowercase "and", and "Oad" should be uppercase "OAD" to match the standard acronym format.

Copilot uses AI. Check for mistakes.
},
"paths": [
{
"description": "oad rules",
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description "oad rules" lacks proper capitalization and is inconsistent with other descriptions in the file. It should use the uppercase acronym "OAD" and follow a more descriptive pattern similar to other entries. Consider something like "OpenAPI Diff (OAD) rules documentation" or "OAD rules documentation".

Suggested change
"description": "oad rules",
"description": "OpenAPI Diff (OAD) rules documentation",

Copilot uses AI. Check for mistakes.
{
"description": "Azure REST API Breaking Change And Oad Rules Mapping",
"path": "/documentation/BreakingChange-Oad-Rules-Mapping.md",
"folder": "static_azure_docs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can not reuse the static_azure_docs folder of the storage container, the folder with 'static' prefix only for the documents uploaded to the storage by manual but not by sync pipeline. You should define a new folder like 'azure_rest_api_specs_docs'

{
"description": "oad rules",
"path": "/docs",
"folder": "static_azure_docs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as this one

@JiaqiZhang-Dev
Copy link
Member

After fix the config, you should follow this document to add the new knowledge source and update the tenant config: https://github.com/Azure/azure-sdk-tools/blob/main/tools/sdk-ai-bots/docs/SELF_SERVE_ADD_KNOWLEDGE_SOURCES.md

{
"repository": {
"url": "https://github.com/Azure/azure-rest-api-specs.git",
"branch": "master",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo uses main not master as the default branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants