Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -267,12 +267,12 @@ describe('ReviewPageOptionsComponent', () => {
expect(result).toBe(true);
});

it('should handle empty package version - should still disable when copilot required', () => {
it('should return false when package version is missing (empty string)', () => {
component.activeAPIRevision!.packageVersion = '';
const isReviewByCopilotRequired = true;
const isVersionReviewedByCopilot = false;
const result = component['shouldDisableApproval'](isReviewByCopilotRequired, isVersionReviewedByCopilot);
expect(result).toBe(true);
expect(result).toBe(false); // Can't require Copilot review without version to track
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,7 @@ export class ReviewPageOptionsComponent implements OnInit, OnChanges {
if (this.isPreviewVersion()) return false;
if (this.activeAPIRevisionIsApprovedByCurrentUser) return false;

if (!this.activeAPIRevision?.packageVersion) return false;
return isReviewByCopilotRequired && !isVersionReviewedByCopilot;
}

Expand Down
Loading