Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 26, 2026

AZC0012 (single-word type name detection) is now implemented in the new analyzer package. This removes the duplicate implementation from Azure.ClientSdk.Analyzers only.

Changes

Removed from Azure.ClientSdk.Analyzers:

  • TypeNameAnalyzer.cs - AZC0012 implementation
  • AZC0012 descriptor from Descriptors.cs
  • AZC0012Tests.cs - all test cases

No changes to other files:

  • ErrorAnalyzers package remains unchanged (prompts, tests, samples all retain AZC0012 support)
  • Documentation references to AZC0012 remain unchanged
  • test-proxy NoWarn list remains unchanged (still includes AZC0012)

Preserved:

  • NamingSuggestionHelper.cs - used by multiple analyzers (AZC0034, AZC0030, AZC0031, AZC0032, AZC0033, AZC0036)
  • All AZC0012 references outside of Azure.ClientSdk.Analyzers - error code continues to exist from new package
Original prompt

This section details on the original issue you should resolve

<issue_title>Need to remove AZC0012 since its implemented in the new analyzer package</issue_title>
<issue_description>Remove duplicate AZC0012 after Azure/azure-sdk-for-net#55248 finishes</issue_description>

<agent_instructions>Get the pr ready even though the linked issue isn't finished</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 26, 2026 23:24
Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>
Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove AZC0012 as it is implemented in the new analyzer package Remove duplicate AZC0012 analyzer Jan 26, 2026
Copilot AI requested a review from m-nash January 26, 2026 23:32
Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 27, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 1p7vsblobprodcus324.vsblob.vsassets.io
    • Triggering command: /usr/share/dotnet/dotnet dotnet test Azure.ClientSdk.Analyzers.sln (dns block)
  • 1s1vsblobprodcus386.vsblob.vsassets.io
    • Triggering command: /usr/share/dotnet/dotnet dotnet test Azure.ClientSdk.Analyzers.sln (dns block)
  • 5rqvsblobprodcus385.vsblob.vsassets.io
    • Triggering command: /usr/share/dotnet/dotnet dotnet test Azure.ClientSdk.Analyzers.sln (dns block)
  • c78vsblobprodcus322.vsblob.vsassets.io
    • Triggering command: /usr/share/dotnet/dotnet dotnet test Azure.ClientSdk.Analyzers.sln (dns block)
  • ibzvsblobprodcus369.vsblob.vsassets.io
    • Triggering command: /usr/share/dotnet/dotnet dotnet test Azure.ClientSdk.Analyzers.sln (dns block)
  • jd4vsblobprodcus366.vsblob.vsassets.io
    • Triggering command: /usr/share/dotnet/dotnet dotnet test Azure.ClientSdk.Analyzers.sln (dns block)
  • k0ivsblobprodcus356.vsblob.vsassets.io
    • Triggering command: /usr/share/dotnet/dotnet dotnet test Azure.ClientSdk.Analyzers.sln (dns block)
  • pe3vsblobprodcus354.vsblob.vsassets.io
    • Triggering command: /usr/share/dotnet/dotnet dotnet test Azure.ClientSdk.Analyzers.sln (dns block)
  • s8mvsblobprodcus38.vsblob.vsassets.io
    • Triggering command: /usr/share/dotnet/dotnet dotnet test Azure.ClientSdk.Analyzers.sln (dns block)
  • st8vsblobprodcus339.vsblob.vsassets.io
    • Triggering command: /usr/share/dotnet/dotnet dotnet test Azure.ClientSdk.Analyzers.sln (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from m-nash January 27, 2026 22:08
Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to remove AZC0012 since its implemented in the new analyzer package

2 participants