Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

APIView depends on Azure.ClientSdk.Analyzers via ProjectReference but changes to the analyzers aren't verified against APIView before merge.

Changes

  • Added src/dotnet/Azure.ClientSdk.Analyzers to the pr path filters in src/dotnet/APIView/apiview.yml

When PRs are created that modify Azure.ClientSdk.Analyzers, the APIView CI will automatically trigger. The APIView CI already builds the APIView project, which has a ProjectReference dependency on Azure.ClientSdk.Analyzers, so any breaking changes to the analyzers will be caught during the APIView build process before the PR is merged.

Note: The path is only added to PR triggers, not to regular triggers, to prevent unnecessary CI runs on direct commits to main while still providing verification during the PR review process.

Warning

<issue_title>Update CI for Azure.ClientSdk.Analyzers to verify that ApiView still builds</issue_title>
<issue_description>This project https://github.com/Azure/azure-sdk-tools/blob/main/src/dotnet/APIView/APIView/APIView.csproj depends on Azure.ClientSdk.Analyzers so we should verify it still builds when changing the analyzers in the CI.</issue_description>

Comments on the Issue (you are @copilot in this section)

<issue_title>Update CI for Azure.ClientSdk.Analyzers to verify that ApiView still builds</issue_title>

<issue_description>This project https://github.com/Azure/azure-sdk-tools/blob/main/src/dotnet/APIView/APIView/APIView.csproj depends on Azure.ClientSdk.Analyzers so we should verify it still builds when changing the analyzers in the CI.</issue_description>

Comments on the Issue (you are @copilot in this section)

Original prompt

This section details on the original issue you should resolve

<issue_title>Update CI for Azure.ClientSdk.Analyzers to verify that ApiView still builds</issue_title>
<issue_description>This project https://github.com/Azure/azure-sdk-tools/blob/main/src/dotnet/APIView/APIView/APIView.csproj depends on Azure.ClientSdk.Analyzers so we should verify it still builds when changing the analyzers in the CI.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update CI to verify ApiView builds with Azure.ClientSdk.Analyzers Add APIView build verification to Azure.ClientSdk.Analyzers CI Jan 30, 2026
Copilot AI changed the title Add APIView build verification to Azure.ClientSdk.Analyzers CI Trigger APIView CI when Azure.ClientSdk.Analyzers changes Feb 4, 2026
Copilot AI requested a review from m-nash February 4, 2026 17:28
Copilot AI changed the title Trigger APIView CI when Azure.ClientSdk.Analyzers changes Trigger APIView CI on PRs when Azure.ClientSdk.Analyzers changes Feb 4, 2026
Copilot AI requested a review from m-nash February 4, 2026 17:53
@m-nash m-nash marked this pull request as ready for review February 4, 2026 18:47
Copilot AI review requested due to automatic review settings February 4, 2026 18:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates APIView’s Azure Pipelines configuration so that pull requests modifying Azure.ClientSdk.Analyzers also trigger the APIView CI, ensuring APIView continues to build against analyzer changes before merge.

Changes:

  • Added src/dotnet/Azure.ClientSdk.Analyzers to the PR path filters in src/dotnet/APIView/apiview.yml (without changing main-branch triggers).

@m-nash
Copy link
Member

m-nash commented Feb 4, 2026

/check-enforcer override

@m-nash m-nash merged commit 746103d into main Feb 4, 2026
21 checks passed
@m-nash m-nash deleted the copilot/update-ci-azure-client-sdk branch February 4, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CI for Azure.ClientSdk.Analyzers to verify that ApiView still builds

3 participants