Skip to content

Conversation

@docEdub
Copy link
Contributor

@docEdub docEdub commented Jan 14, 2026

No description provided.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 14, 2026

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 14, 2026

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 14, 2026

Snapshot stored with reference name:
refs/pull/17680/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17680/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17680/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/17680/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17680/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17680/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17680/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17680/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 14, 2026

Smart Filters Editor is available to test at:
https://sfe.babylonjs.com/?snapshot=refs/pull/17680/merge

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 14, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 14, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 14, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 14, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 14, 2026

@docEdub
Copy link
Contributor Author

docEdub commented Jan 14, 2026

Testing this change with older versions of TypeScript shows it works fine for TS 5.7.3 and newer, but 5.6.3 and older has the following errors:

    packages/public/@babylonjs/core/Engines/thinNativeEngine.d.ts(533,135): error TS2315: Type 'ArrayBufferView' is not generic.
    packages/public/@babylonjs/core/Meshes/GaussianSplatting/gaussianSplattingMesh.d.ts(344,13): error TS2315: Type 'Uint8Array' is not generic.
    packages/public/@babylonjs/core/Meshes/GaussianSplatting/gaussianSplattingMesh.d.ts(372,13): error TS2315: Type 'Uint8Array' is not generic.

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try to remove the " as " whenever possible by changing the targetted types ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants