W3 fs 1299 #9
Open
W3 fs 1299 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `useChat` hook to accept an optional `initialSession` parameter for initializing chat history. - Modified `ChatComponent` to handle read-only mode and pass the initial session to the chat hook. - Enhanced `useSessionManager` to skip loading the current session if chat history is already populated. - Added session sharing capabilities in the `SessionSidebar`, including loading and managing session shares. - Introduced new API endpoints for creating, retrieving, and deleting session shares in the backend. This update improves user experience by allowing session persistence and sharing, enhancing the overall chat functionality.
…n; update Go dependencies
- Introduced Redis configuration and client creation in the plugin. - Implemented fallback logic for in-memory storage if Redis is unavailable. - Updated health check to include Redis connection status. - Added Redis service to docker-compose for local development.
- Updated ShareDialog to handle expiration options for shares, including "Never" and specific durations in hours and days. - Modified sessionShareService to accept both hours and days for expiration, improving flexibility. - Adjusted tests to validate new expiration logic and ensure correct behavior for share creation. - Refactored session management to support immediate saving of chat history and session states. - Cleaned up unused import and export functionalities in the session sidebar component.
- Fixed issues with session sharing expiration options not being applied correctly. - Ensured that both "Never" and specific duration settings are functioning as intended. - Updated related tests to cover edge cases for expiration logic.
…r handling - Enhanced the test for revoking session shares by ensuring the "Create Another Share" button is visible after a share is created. - Added checks for the visibility of the "Existing Shares" label before locating the revoke button. - Updated error handling test to avoid strict mode violations by using the first() method for the error message element.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ARG development=false | ||
| ARG TARGETARCH | ||
|
|
||
| ARG GO_VERSION=1.21.6 |
There was a problem hiding this comment.
Go version mismatch between go.mod and Dockerfile
High Severity
The Dockerfile uses GO_VERSION=1.21.6 while go.mod requires go 1.25.5. This version mismatch will cause Go compilation failures when building the backend in Docker, as Go 1.21.6 cannot compile code requiring Go 1.25.5 language features and standard library changes.
Additional Locations (1)
| "version": "0.1.1", | ||
| "scripts": { | ||
| "build": "npm run build:frontend && npm run build:backend", | ||
| "build": "webpack -c ./.config/webpack/webpack.config.ts --env production", |
There was a problem hiding this comment.
Webpack config path inconsistency in build script
Medium Severity
The build script references ./.config/webpack/webpack.config.ts but other scripts use ./webpack.config.ts. This inconsistent path will cause the build command to fail if webpack.config.ts is not in the .config/webpack/ directory.
| "build:frontend:coverage": "COVERAGE=true webpack -c ./webpack.config.ts --env development --env coverage", | ||
| "build:frontend:coverage:prod": "COVERAGE=true webpack -c ./webpack.config.ts --env production --env coverage", | ||
| "build:backend": "go run github.com/magefile/mage@latest build", | ||
| "build:backend": "go run github.com/magefile/mage@latest build:backend", |
There was a problem hiding this comment.
Magefile build target mismatch with npm scripts
High Severity
The npm script calls mage build:backend but the new Magefile imports build targets as build.BuildAll, using the standard SDK pattern. The build:backend target doesn't exist, causing backend builds to fail.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduces secure per-user OAuth for MCP and streamlines tooling.
OAuthFlowManager, token storage/refresh, and Bearer injection viacustomRoundTripper; client calls now acceptuserIDand refresh on 401Clientmethods (connectMCPWithOrgContext, OpenAPI/MCP/standard calls) to use OAuth-aware HTTP clients.envdefaults@grafana/plugin-validator; cleans packaging steps; adds provenance in releaseMagefileto SDK buildWritten by Cursor Bugbot for commit 5ea8a86. This will update automatically on new commits. Configure here.