Support for the Linux kernel MCTP stack #463
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit supports spdm-requester-emu communicate with other endpoints
via MCTP in kernel. It also supports sending single command GET_VERSION
to test the interface.
Tested:
Send command:
spdm_requester_emu --trans MCTP_KERNEL --eid 20 --cmd GET_VERSION
Sample output:
spdm_requester_emu version 0.1
trans - 0x5
spdm_cmd - 0x01
connect success!
context_size - 0x21d8
libspdm_send_spdm_request[0] msg SPDM_GET_VERSION(0x84), size (0x4):
0000: 10 84 00 00
Platform port Transmit transport_type: 00 00 00 05
Platform port Transmit size: 00 00 00 05
Platform port Transmit buffer:
05 10 84 00 00
Platform port Receive buffer:
05 10 04 00 00 00 03 00 10 00 11 00 12
libspdm_receive_spdm_response[0] msg SPDM_VERSION(0x4), size (0xc):
0000: 10 04 00 00 00 03 00 10 00 11 00 12
Client stopped
Signed-off-by: Quang Nguyen <quangnguyen@os.amperecomputing.com>
Author
|
Waiting on build results from the VS2019 targets, as I don't have a setup for that at the moment. |
wmaroneAMD
force-pushed
the
ntnq-kernel
branch
from
af12f41 to
6930935
Compare
wmaroneAMD
force-pushed
the
ntnq-kernel
branch
from
6930935 to
f8bea39
Compare
This commit cleans up the changes made to implement support for the Linux kernel's MCTP stack. Things addressed: * Removal of the single command capability, as it did not build successfully and ultimately is not needed. * Wrap Linux-specific conditions and use of MCTP_KERNEL in negative checks for _MSC_VER to exclude it from Windows builds. * Adjusted naming of constant to be more specific * Removed unusable links in comments Signed-off-by: Will Marone <Will.Marone@amd.com>
wmaroneAMD
force-pushed
the
ntnq-kernel
branch
from
f8bea39 to
d84899a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates #341 as it has been abandoned for over a year and I cannot contact the author.
I have addressed the comments within the original PR and have tested it using a custom build of 6.14 with CONFIG_MCTP and CONFIG_MCTP_SERIAL, routed into a QEMU instance running spdm-lib as a target.