-
Notifications
You must be signed in to change notification settings - Fork 324
Avoid final field mutation in CapturedSnapshotTest #10440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bbujon/jep500
Are you sure you want to change the base?
Avoid final field mutation in CapturedSnapshotTest #10440
Conversation
d65bf18 to
d88e1b4
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (333.489 µs) : 269, 398
. : milestone, 333,
basic (278.035 µs) : 272, 284
. : milestone, 278,
loop (8.959 ms) : 8954, 8963
. : milestone, 8959,
section candidate
noprobe (310.592 µs) : 283, 338
. : milestone, 311,
basic (279.672 µs) : 271, 289
. : milestone, 280,
loop (8.962 ms) : 8958, 8966
. : milestone, 8962,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 8 performance regressions! Performance is the same for 51 metrics, 6 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~b5ee6b5b66, baseline=1.59.0-SNAPSHOT~a34cb643aa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1101053
Total [baseline] (10.704 s) : 0, 10703535
Agent [candidate] (1.086 s) : 0, 1085515
Total [candidate] (10.797 s) : 0, 10797342
section appsec
Agent [baseline] (1.272 s) : 0, 1272044
Total [baseline] (11.164 s) : 0, 11163573
Agent [candidate] (1.278 s) : 0, 1278164
Total [candidate] (11.034 s) : 0, 11034498
section iast
Agent [baseline] (1.232 s) : 0, 1232442
Total [baseline] (11.136 s) : 0, 11136077
Agent [candidate] (1.226 s) : 0, 1226342
Total [candidate] (11.045 s) : 0, 11045457
section profiling
Agent [baseline] (1.211 s) : 0, 1210549
Total [baseline] (10.959 s) : 0, 10959191
Agent [candidate] (1.231 s) : 0, 1231074
Total [candidate] (11.003 s) : 0, 11002993
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~b5ee6b5b66, baseline=1.59.0-SNAPSHOT~a34cb643aa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (659.772 ms) : 0, 659772
BytebuddyAgent [candidate] (649.621 ms) : 0, 649621
GlobalTracer [baseline] (259.726 ms) : 0, 259726
GlobalTracer [candidate] (285.427 ms) : 0, 285427
AppSec [baseline] (33.279 ms) : 0, 33279
AppSec [candidate] (32.624 ms) : 0, 32624
Debugger [baseline] (68.533 ms) : 0, 68533
Debugger [candidate] (66.416 ms) : 0, 66416
Remote Config [baseline] (626.11 µs) : 0, 626
Remote Config [candidate] (610.953 µs) : 0, 611
Telemetry [baseline] (9.159 ms) : 0, 9159
Telemetry [candidate] (8.913 ms) : 0, 8913
Flare Poller [baseline] (3.693 ms) : 0, 3693
Flare Poller [candidate] (5.26 ms) : 0, 5260
AgentMeter [baseline] (29.315 ms) : 0, 29315
section appsec
crashtracking [baseline] (1.169 ms) : 0, 1169
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (692.864 ms) : 0, 692864
BytebuddyAgent [candidate] (696.744 ms) : 0, 696744
GlobalTracer [baseline] (251.232 ms) : 0, 251232
GlobalTracer [candidate] (263.997 ms) : 0, 263997
AppSec [baseline] (173.788 ms) : 0, 173788
AppSec [candidate] (174.338 ms) : 0, 174338
Debugger [baseline] (67.374 ms) : 0, 67374
Debugger [candidate] (67.604 ms) : 0, 67604
Remote Config [baseline] (690.591 µs) : 0, 691
Remote Config [candidate] (696.679 µs) : 0, 697
Telemetry [baseline] (9.472 ms) : 0, 9472
Telemetry [candidate] (9.297 ms) : 0, 9297
Flare Poller [baseline] (3.598 ms) : 0, 3598
Flare Poller [candidate] (3.617 ms) : 0, 3617
AgentMeter [baseline] (11.945 ms) : 0, 11945
IAST [baseline] (24.392 ms) : 0, 24392
IAST [candidate] (24.988 ms) : 0, 24988
section iast
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (795.56 ms) : 0, 795560
BytebuddyAgent [candidate] (791.569 ms) : 0, 791569
GlobalTracer [baseline] (248.245 ms) : 0, 248245
GlobalTracer [candidate] (258.707 ms) : 0, 258707
AppSec [baseline] (32.593 ms) : 0, 32593
AppSec [candidate] (32.532 ms) : 0, 32532
Debugger [baseline] (68.632 ms) : 0, 68632
Debugger [candidate] (67.543 ms) : 0, 67543
Remote Config [baseline] (536.936 µs) : 0, 537
Remote Config [candidate] (533.107 µs) : 0, 533
Telemetry [baseline] (8.586 ms) : 0, 8586
Telemetry [candidate] (8.453 ms) : 0, 8453
Flare Poller [baseline] (3.468 ms) : 0, 3468
Flare Poller [candidate] (3.443 ms) : 0, 3443
AgentMeter [baseline] (11.276 ms) : 0, 11276
IAST [baseline] (26.956 ms) : 0, 26956
IAST [candidate] (26.985 ms) : 0, 26985
section profiling
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.251 ms) : 0, 1251
BytebuddyAgent [baseline] (704.234 ms) : 0, 704234
BytebuddyAgent [candidate] (716.257 ms) : 0, 716257
GlobalTracer [baseline] (215.814 ms) : 0, 215814
GlobalTracer [candidate] (228.678 ms) : 0, 228678
AppSec [baseline] (32.471 ms) : 0, 32471
AppSec [candidate] (33.241 ms) : 0, 33241
Debugger [baseline] (67.451 ms) : 0, 67451
Debugger [candidate] (68.599 ms) : 0, 68599
Remote Config [baseline] (601.091 µs) : 0, 601
Remote Config [candidate] (615.606 µs) : 0, 616
Telemetry [baseline] (8.87 ms) : 0, 8870
Telemetry [candidate] (8.996 ms) : 0, 8996
Flare Poller [baseline] (9.288 ms) : 0, 9288
Flare Poller [candidate] (3.782 ms) : 0, 3782
AgentMeter [baseline] (8.842 ms) : 0, 8842
ProfilingAgent [baseline] (91.801 ms) : 0, 91801
ProfilingAgent [candidate] (98.475 ms) : 0, 98475
Profiling [baseline] (92.396 ms) : 0, 92396
Profiling [candidate] (99.059 ms) : 0, 99059
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~b5ee6b5b66, baseline=1.59.0-SNAPSHOT~a34cb643aa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091999
Total [baseline] (8.76 s) : 0, 8759732
Agent [candidate] (1.09 s) : 0, 1090115
Total [candidate] (8.756 s) : 0, 8756054
section iast
Agent [baseline] (1.23 s) : 0, 1229834
Total [baseline] (9.303 s) : 0, 9303096
Agent [candidate] (1.227 s) : 0, 1227403
Total [candidate] (9.315 s) : 0, 9314992
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~b5ee6b5b66, baseline=1.59.0-SNAPSHOT~a34cb643aa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (654.501 ms) : 0, 654501
BytebuddyAgent [candidate] (653.153 ms) : 0, 653153
GlobalTracer [baseline] (257.869 ms) : 0, 257869
GlobalTracer [candidate] (286.663 ms) : 0, 286663
AppSec [baseline] (33.154 ms) : 0, 33154
AppSec [candidate] (32.94 ms) : 0, 32940
Debugger [baseline] (67.342 ms) : 0, 67342
Debugger [candidate] (64.95 ms) : 0, 64950
Remote Config [baseline] (631.608 µs) : 0, 632
Remote Config [candidate] (616.498 µs) : 0, 616
Telemetry [baseline] (9.033 ms) : 0, 9033
Telemetry [candidate] (8.971 ms) : 0, 8971
Flare Poller [baseline] (3.624 ms) : 0, 3624
Flare Poller [candidate] (6.075 ms) : 0, 6075
AgentMeter [baseline] (29.144 ms) : 0, 29144
section iast
crashtracking [baseline] (1.174 ms) : 0, 1174
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (794.106 ms) : 0, 794106
BytebuddyAgent [candidate] (793.114 ms) : 0, 793114
GlobalTracer [baseline] (247.848 ms) : 0, 247848
GlobalTracer [candidate] (259.265 ms) : 0, 259265
AppSec [baseline] (33.75 ms) : 0, 33750
AppSec [candidate] (35.111 ms) : 0, 35111
Debugger [baseline] (67.044 ms) : 0, 67044
Debugger [candidate] (63.834 ms) : 0, 63834
Remote Config [baseline] (548.358 µs) : 0, 548
Remote Config [candidate] (538.044 µs) : 0, 538
Telemetry [baseline] (8.479 ms) : 0, 8479
Telemetry [candidate] (8.494 ms) : 0, 8494
Flare Poller [baseline] (3.442 ms) : 0, 3442
Flare Poller [candidate] (3.431 ms) : 0, 3431
AgentMeter [baseline] (11.257 ms) : 0, 11257
IAST [baseline] (26.8 ms) : 0, 26800
IAST [candidate] (27.133 ms) : 0, 27133
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~b5ee6b5b66, baseline=1.59.0-SNAPSHOT~a34cb643aa
dateFormat X
axisFormat %s
section baseline
no_agent (18.348 ms) : 18157, 18539
. : milestone, 18348,
appsec (18.727 ms) : 18535, 18919
. : milestone, 18727,
code_origins (17.793 ms) : 17615, 17971
. : milestone, 17793,
iast (17.825 ms) : 17648, 18002
. : milestone, 17825,
profiling (18.956 ms) : 18768, 19144
. : milestone, 18956,
tracing (17.797 ms) : 17622, 17972
. : milestone, 17797,
section candidate
no_agent (19.151 ms) : 18956, 19346
. : milestone, 19151,
appsec (18.374 ms) : 18187, 18561
. : milestone, 18374,
code_origins (17.726 ms) : 17551, 17902
. : milestone, 17726,
iast (17.721 ms) : 17544, 17897
. : milestone, 17721,
profiling (19.819 ms) : 19618, 20021
. : milestone, 19819,
tracing (18.155 ms) : 17976, 18335
. : milestone, 18155,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~b5ee6b5b66, baseline=1.59.0-SNAPSHOT~a34cb643aa
dateFormat X
axisFormat %s
section baseline
no_agent (1.171 ms) : 1159, 1182
. : milestone, 1171,
iast (3.269 ms) : 3224, 3314
. : milestone, 3269,
iast_FULL (5.748 ms) : 5690, 5806
. : milestone, 5748,
iast_GLOBAL (3.593 ms) : 3534, 3653
. : milestone, 3593,
profiling (2.039 ms) : 2021, 2057
. : milestone, 2039,
tracing (1.815 ms) : 1799, 1830
. : milestone, 1815,
section candidate
no_agent (1.181 ms) : 1170, 1193
. : milestone, 1181,
iast (3.304 ms) : 3256, 3353
. : milestone, 3304,
iast_FULL (5.646 ms) : 5591, 5701
. : milestone, 5646,
iast_GLOBAL (3.606 ms) : 3548, 3664
. : milestone, 3606,
profiling (2.067 ms) : 2046, 2088
. : milestone, 2067,
tracing (1.766 ms) : 1751, 1781
. : milestone, 1766,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~b5ee6b5b66, baseline=1.59.0-SNAPSHOT~a34cb643aa
dateFormat X
axisFormat %s
section baseline
no_agent (15.38 s) : 15380000, 15380000
. : milestone, 15380000,
appsec (14.639 s) : 14639000, 14639000
. : milestone, 14639000,
iast (17.732 s) : 17732000, 17732000
. : milestone, 17732000,
iast_GLOBAL (18.113 s) : 18113000, 18113000
. : milestone, 18113000,
profiling (15.429 s) : 15429000, 15429000
. : milestone, 15429000,
tracing (14.807 s) : 14807000, 14807000
. : milestone, 14807000,
section candidate
no_agent (15.552 s) : 15552000, 15552000
. : milestone, 15552000,
appsec (14.811 s) : 14811000, 14811000
. : milestone, 14811000,
iast (17.736 s) : 17736000, 17736000
. : milestone, 17736000,
iast_GLOBAL (17.76 s) : 17760000, 17760000
. : milestone, 17760000,
profiling (15.273 s) : 15273000, 15273000
. : milestone, 15273000,
tracing (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~b5ee6b5b66, baseline=1.59.0-SNAPSHOT~a34cb643aa
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1490
. : milestone, 1478,
appsec (3.693 ms) : 3476, 3909
. : milestone, 3693,
iast (2.244 ms) : 2175, 2313
. : milestone, 2244,
iast_GLOBAL (2.287 ms) : 2218, 2356
. : milestone, 2287,
profiling (2.079 ms) : 2023, 2134
. : milestone, 2079,
tracing (2.062 ms) : 2007, 2116
. : milestone, 2062,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (2.452 ms) : 2399, 2504
. : milestone, 2452,
iast (2.199 ms) : 2134, 2264
. : milestone, 2199,
iast_GLOBAL (2.242 ms) : 2177, 2307
. : milestone, 2242,
profiling (2.074 ms) : 2020, 2128
. : milestone, 2074,
tracing (2.031 ms) : 1980, 2083
. : milestone, 2031,
|
46d6ef3 to
b5ee6b5
Compare
What Does This Do
Add a test-only
TEST_INSTANCEto theCorrelationAccessclass. Now instead of mutating a final field inCapturedSnapshotTestto introduce aspy, we can set thespyto be a non-finalTEST_INSTANCE.Motivation
Mutating final fields will introduce warnings starting in Java 26 and be disallowed in a later release (JEP 500).
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/APMLP-594