Skip to content

CI Permissions - dd-octo-sts - Use tag ref instead of branch #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Minosity-VR merged 4 commits into from
Jan 16, 2026
Merged

CI Permissions - dd-octo-sts - Use tag ref instead of branch #724

Minosity-VR merged 4 commits into from
Jan 16, 2026

Conversation

@Minosity-VR
Copy link
Collaborator

@Minosity-VR Minosity-VR commented Jan 16, 2026 •
edited
Loading

What does this PR do?

Bug fix

I made a mistake in #723 - I was testing the CI against the branch name, and not the tag directly.

  • Fix the trust policy to accept workflows started from tags
  • Add the default permissions back. the token generated by dd-octo-sts is used only in one step. the other steps still need contents:read

christophetd
christophetd reviewed Jan 16, 2026
View reviewed changes
@Minosity-VR
Copy link
Collaborator Author

Minosity-VR commented Jan 16, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 16, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-16 11:54:17 UTC ℹ️ Start processing command /merge

2026-01-16 11:54:22 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).

2026-01-16 12:19:52 UTC ℹ️ MergeQueue: Retrying because an high priority merge request needed to be processed first. No action is needed from your side.

2026-01-16 12:19:55 UTC ⚠️ MergeQueue: This merge request build was cancelled

simon.marechal@datadoghq.com cancelled this merge request build

@Minosity-VR
Copy link
Collaborator Author

Minosity-VR commented Jan 16, 2026

/merge -c

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 16, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-16 12:19:46 UTC ℹ️ Start processing command /merge -c

@Minosity-VR Minosity-VR merged commit db211b7 into main Jan 16, 2026
5 of 6 checks passed
@Minosity-VR Minosity-VR deleted the simon.marechal/fix-octo-sts branch January 16, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophetd christophetd christophetd approved these changes

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Minosity-VR @christophetd